View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0004955ardourotherpublic2012-06-27 05:152020-04-19 20:16
ReporterJaaxxOne Assigned Topaul  
PrioritynormalSeveritytweakReproducibilityN/A
Status closedResolutionfixed 
Target Version3.0 
Summary0004955: [PATCH] Fixes for transport controls/mixer-on-top in Korg nano maps.
DescriptionThe Korg transport buttons send out a CC msg value of 127 on press and another of 0 on release. This is the real reason the rec-enable function was not working properly. Using action="Transport/Record" works because it somehow ignores the release CC msg, where function="rec-enable" does not (at least when it comes to toggling "off".) The real fix is to bind on the press msg explicitly so the release msg gets ignored.

This also fixes loop function (activates and instantly deactivates) as well as oddities when goto-start is pressed (would sometimes auto play with transport stopped.)
Additional InformationPer feedback from Colinf (see 0004952) mixer-on-top will not work with midi messages anymore. Workaround is to use toggle-mixer which is somewhat slower, but achieves the desired result.

Attached patch addresses both issues across both Korg nano maps.
TagsNo tags attached.

Relationships

related to 0004953 closedcth103 [PATCH] Fix rec-enable behavior in Korg_nanoKONTROL.map 

Activities

2012-06-27 05:15

 

korg_transport_fix.patch (2,668 bytes)    
Index: midi_maps/Korg_nanoKONTROL.map
===================================================================
--- midi_maps/Korg_nanoKONTROL.map
+++ midi_maps/Korg_nanoKONTROL.map
@@ -5,12 +5,12 @@
   <DeviceInfo bank-size="9" motorized="no" threshold="15"/>
 
 <!-- Transport Controls -->
-  <Binding channel="1" ctl="44" action="Transport/Record"/>
-  <Binding channel="1" ctl="45" function="transport-roll"/>
-  <Binding channel="1" ctl="46" function="transport-stop"/>
-  <Binding channel="1" ctl="47" function="transport-start"/>
-  <Binding channel="1" ctl="48" function="transport-end"/>
-  <Binding channel="1" ctl="49" function="loop-toggle"/>
+  <Binding msg="B0 2c 7f" function="rec-enable"/>
+  <Binding msg="B0 2d 7f" function="transport-roll"/>
+  <Binding msg="B0 2e 7f" function="transport-stop"/>
+  <Binding msg="B0 2f 7f" function="transport-start"/>
+  <Binding msg="B0 30 7f" function="transport-end"/>
+  <Binding msg="B0 31 7f" function="loop-toggle"/>
 
 <!-- The "Scene" button toggles between four banks. For this to work as     -->
 <!-- intended, you have to configure all four scenes to be identical.       -->
Index: midi_maps/Korg_nanoKONTROL_Master.map
===================================================================
--- midi_maps/Korg_nanoKONTROL_Master.map
+++ midi_maps/Korg_nanoKONTROL_Master.map
@@ -8,12 +8,12 @@
   <DeviceInfo bank-size="8" motorized="no" threshold="15"/>
 
 <!-- Transport Controls -->
-  <Binding channel="1" ctl="44" action="Transport/Record"/>
-  <Binding channel="1" ctl="45" action="Transport/TransitionToRoll"/>
-  <Binding channel="1" ctl="46" function="transport-stop"/>
-  <Binding channel="1" ctl="47" action="Transport/GotoStart"/>
-  <Binding channel="1" ctl="48" action="Transport/GotoEnd"/>
-  <Binding channel="1" ctl="49" action="Transport/Loop"/>
+  <Binding msg="B0 2c 7f" function="rec-enable"/>
+  <Binding msg="B0 2d 7f" function="transport-roll"/>
+  <Binding msg="B0 2e 7f" function="transport-stop"/>
+  <Binding msg="B0 2f 7f" function="transport-start"/>
+  <Binding msg="B0 30 7f" function="transport-end"/>
+  <Binding msg="B0 31 7f" function="loop-toggle"/>
 
 <!-- The "Scene" button toggles between four banks. It implements this by   -->
 <!-- sending a bank assignment # corresponding to the current korg "Scene"  -->
@@ -89,7 +89,7 @@
 
 <!-- Strip 9 : Master -->
   <Binding channel="1" ctl="22" uri="/bus/panwidth master"/>
-  <Binding channel="1" ctl="31" action="Common/toggle-mixer-on-top"/>
+  <Binding channel="1" ctl="31" action="Common/toggle-mixer"/>
   <Binding channel="1" ctl="41" uri="/bus/mute master"/>
   <Binding channel="1" ctl="13" uri="/bus/gain master"/>
korg_transport_fix.patch (2,668 bytes)   

2012-07-01 20:28

 

korg_transport_fix_v2.patch (2,147 bytes)    
Index: midi_maps/Korg_nanoKONTROL.map
===================================================================
--- midi_maps/Korg_nanoKONTROL.map
+++ midi_maps/Korg_nanoKONTROL.map
@@ -5,12 +5,12 @@
   <DeviceInfo bank-size="9" motorized="no" threshold="15"/>
 
 <!-- Transport Controls -->
-  <Binding channel="1" ctl="44" action="Transport/Record"/>
-  <Binding channel="1" ctl="45" function="transport-roll"/>
-  <Binding channel="1" ctl="46" function="transport-stop"/>
-  <Binding channel="1" ctl="47" function="transport-start"/>
-  <Binding channel="1" ctl="48" function="transport-end"/>
-  <Binding channel="1" ctl="49" function="loop-toggle"/>
+  <Binding msg="B0 2c 7f" function="rec-enable"/>
+  <Binding msg="B0 2d 7f" function="transport-roll"/>
+  <Binding msg="B0 2e 7f" function="transport-stop"/>
+  <Binding msg="B0 2f 7f" function="transport-start"/>
+  <Binding msg="B0 30 7f" function="transport-end"/>
+  <Binding msg="B0 31 7f" function="loop-toggle"/>
 
 <!-- The "Scene" button toggles between four banks. For this to work as     -->
 <!-- intended, you have to configure all four scenes to be identical.       -->
Index: midi_maps/Korg_nanoKONTROL_Master.map
===================================================================
--- midi_maps/Korg_nanoKONTROL_Master.map
+++ midi_maps/Korg_nanoKONTROL_Master.map
@@ -8,12 +8,12 @@
   <DeviceInfo bank-size="8" motorized="no" threshold="15"/>
 
 <!-- Transport Controls -->
-  <Binding channel="1" ctl="44" action="Transport/Record"/>
-  <Binding channel="1" ctl="45" action="Transport/TransitionToRoll"/>
-  <Binding channel="1" ctl="46" function="transport-stop"/>
-  <Binding channel="1" ctl="47" action="Transport/GotoStart"/>
-  <Binding channel="1" ctl="48" action="Transport/GotoEnd"/>
-  <Binding channel="1" ctl="49" action="Transport/Loop"/>
+  <Binding msg="B0 2c 7f" function="rec-enable"/>
+  <Binding msg="B0 2d 7f" function="transport-roll"/>
+  <Binding msg="B0 2e 7f" function="transport-stop"/>
+  <Binding msg="B0 2f 7f" function="transport-start"/>
+  <Binding msg="B0 30 7f" function="transport-end"/>
+  <Binding msg="B0 31 7f" function="loop-toggle"/>
korg_transport_fix_v2.patch (2,147 bytes)   

JaaxxOne

2012-07-01 20:32

reporter   ~0013761

Per 0004952 toggle-mixer-on-top is now working. I submitted korg_transport_fix_v2.patch to remove the change to toggle-mixer. Please apply the v2 patch only to address the double cc message issue and consequently the broken loop function.

phdemartin

2012-07-01 22:41

reporter   ~0013762

to reach the right behavior : toggle the Global Record with the same button.
I had to edit the signal of my nanokorg 2 with the Korg Control Editor assigning "Button behavior" to toggle (it was on Momentary)
and edit my map to (for the NanoKorg2)
  <Binding msg="B0 2d 7f" function="rec-enable"/>
  <Binding msg="B0 2d 00" function="rec-disable"/>

(for the original NanoKorg it would be)
  <Binding msg="B0 2c 7f" function="rec-enable"/>
  <Binding msg="B0 2c 00" function="rec-disable"/>

Now it work, but still, the stop button disarm the Global Record, it can be anoying if you want to make a serie of recording take .

JaaxxOne

2012-07-02 01:39

reporter   ~0013763

The stop button behavior is intentional. There is an option in Preferences to NOT rec-disable on stop.

2012-07-02 03:48

 

Korg_nanoKONTROL2.map (3,931 bytes)

2012-07-02 03:48

 

Korg_nanoKONTROL2_With_Master.map (4,331 bytes)

phdemartin

2012-07-02 03:54

reporter   ~0013764

Ok now
I've uploaded two maps for the Korg NanoKontrol2
First: with the 8 channels assigned to tracks
Second: 7 Channel to tracks and the last to the master

They are complete, every things working.
They are commented and have instructions to assign properly the ID's.
I don't know where to upload them to be incorporated to the SVN

JaaxxOne

2012-07-02 04:01

reporter   ~0013765

Probably want to start a new issue for those since you're working with the nanoKontrol2 instead of the original nanoKontrol. 2 different devices.

phdemartin

2012-07-02 04:06

reporter   ~0013766

Ok

paul

2012-07-09 21:31

administrator   ~0013826

committed in rev 13003

system

2020-04-19 20:16

developer   ~0023098

Issue has been closed automatically, by Trigger Close Plugin.
Feel free to re-open with additional information if you think the issue is not resolved.

Issue History

Date Modified Username Field Change
2012-06-27 05:15 JaaxxOne New Issue
2012-06-27 05:15 JaaxxOne File Added: korg_transport_fix.patch
2012-06-28 11:54 cth103 cost => 0.00
2012-06-28 11:54 cth103 Target Version => 3.0
2012-07-01 20:28 JaaxxOne File Added: korg_transport_fix_v2.patch
2012-07-01 20:32 JaaxxOne Note Added: 0013761
2012-07-01 22:41 phdemartin Note Added: 0013762
2012-07-02 01:39 JaaxxOne Note Added: 0013763
2012-07-02 03:48 phdemartin File Added: Korg_nanoKONTROL2.map
2012-07-02 03:48 phdemartin File Added: Korg_nanoKONTROL2_With_Master.map
2012-07-02 03:54 phdemartin Note Added: 0013764
2012-07-02 04:01 JaaxxOne Note Added: 0013765
2012-07-02 04:06 phdemartin Note Added: 0013766
2012-07-09 21:31 paul Note Added: 0013826
2012-07-09 21:31 paul Status new => resolved
2012-07-09 21:31 paul Resolution open => fixed
2012-07-09 21:31 paul Assigned To => paul
2013-07-23 01:05 paul Relationship added related to 0004953
2020-04-19 20:16 system Note Added: 0023098
2020-04-19 20:16 system Status resolved => closed