View Issue Details

IDProjectCategoryView StatusLast Update
0004952ardourbugspublic2020-04-19 20:16
ReporterJaaxxOne Assigned Tocolinf  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Target Version3.0 
Summary0004952: Common/toggle-mixer-on-top no longer works when used in midi map
DescriptionCommon/toggle-mixer-on-top appears to be broken when implemented in a midi map as such:

<Binding channel="1" ctl="31" action="Common/toggle-mixer-on-top"/>

Possibly related to patch applied in 2477?
TagsNo tags attached.

Activities

colinf

2012-06-26 10:53

updater   ~0013719

Yes, that's very likely a side-effect of the fix for 0002477: sorry!

I don't think it's possible to make 'toggle-mixer-on-top' work reliably from anything other than mouse or keyboard commands, since it's impossible for Ardour to keep track of whether the mixer window has been moved above or below the editor window by other means than 'toggle-mixer-on-top', so it can't know whether it should raise or lower the mixer window in response to the 'toggle-mixer-on-top' action.

I don't have any MIDI control surface, so I can't try this myself, but does using 'action="Common/toggle-mixer"' instead in the MIDI map file do what you want?

JaaxxOne

2012-06-26 17:43

reporter   ~0013728

I can confirm that Common/toggle-mixer does "mimic" the old behavior. Thanks for the tip. In fact it might be even more desirable in the context of a control surface in a multimonitor setup.

It is still a bit odd that mixer-on-top used to work fine. I imagine this issue will pop up again and again as users start working on their own custom maps and expect mixer-on-top to work the same as the keyboard binding.

Would checking for focus solve the raised/lowered state issue? mixer_has_focus() then lower_mixer(), !mixer_has_focus() then raise_mixer()?

colinf

2012-06-27 12:23

updater   ~0013734

Should be fixed in r12952.

JaaxxOne

2012-07-01 20:29

reporter   ~0013760

Working for me as of 12952. Thanks!

colinf

2012-07-02 09:47

updater   ~0013767

Confirmed fixed.

system

2020-04-19 20:16

developer   ~0023095

Issue has been closed automatically, by Trigger Close Plugin.
Feel free to re-open with additional information if you think the issue is not resolved.

Issue History

Date Modified Username Field Change
2012-06-26 03:18 JaaxxOne New Issue
2012-06-26 10:53 colinf Note Added: 0013719
2012-06-26 16:36 cth103 Status new => feedback
2012-06-26 17:06 cth103 cost => 0.00
2012-06-26 17:06 cth103 Target Version => 3.0
2012-06-26 17:43 JaaxxOne Note Added: 0013728
2012-06-27 12:23 colinf Note Added: 0013734
2012-07-01 20:29 JaaxxOne Note Added: 0013760
2012-07-02 09:47 colinf Note Added: 0013767
2012-07-02 09:47 colinf Status feedback => resolved
2012-07-02 09:47 colinf Resolution open => fixed
2012-07-02 09:47 colinf Assigned To => colinf
2020-04-19 20:16 system Note Added: 0023095
2020-04-19 20:16 system Status resolved => closed