View Issue Details

IDProjectCategoryView StatusLast Update
0004953ardourotherpublic2020-04-19 20:16
ReporterJaaxxOne Assigned Tocth103  
PrioritynormalSeveritytweakReproducibilityN/A
Status closedResolutionfixed 
Target Version3.0 
Summary0004953: [PATCH] Fix rec-enable behavior in Korg_nanoKONTROL.map
DescriptionAs per comments in map, there is an issue with the rec-enable not toggling properly, so author bound stop to rec-disable as a workaround.

I found using action="Transport/Record" produces the desired toggle effect properly.

Patch attached - removes rec-disable binding from "Stop" button, removes rec-enable function, implements action="Transport/Record"
TagsNo tags attached.

Relationships

related to 0004955 closedpaul [PATCH] Fixes for transport controls/mixer-on-top in Korg nano maps. 

Activities

2012-06-26 03:26

 

nano_rec_fix.patch (644 bytes)   
Index: midi_maps/Korg_nanoKONTROL.map
===================================================================
--- midi_maps/Korg_nanoKONTROL.map
+++ midi_maps/Korg_nanoKONTROL.map
@@ -5,8 +5,7 @@
   <DeviceInfo bank-size="9" motorized="no" threshold="15"/>
 
 <!-- Transport Controls -->
-  <Binding channel="1" ctl="44" function="rec-enable"/>
-  <Binding channel="1" ctl="46" function="rec-disable"/>
+  <Binding channel="1" ctl="44" action="Transport/Record"/>
   <Binding channel="1" ctl="45" function="transport-roll"/>
   <Binding channel="1" ctl="46" function="transport-stop"/>
   <Binding channel="1" ctl="47" function="transport-start"/>
nano_rec_fix.patch (644 bytes)   

cth103

2012-06-26 17:13

administrator   ~0013726

Applied to SVN 12942. Thanks!

phdemartin

2012-07-01 14:38

reporter   ~0013758

Last edited: 2012-07-01 15:10

I've compiled the last svn and transferred the change to my NanoKontrol 2 map.
It's working as described but I don't thing it's optimal, in the Gui, to arm and disarm the global record, you click on the same button, I thing, it would be better if the midi surface would mimic the gui behavior instead of assigning the record button to arm the global record and the stop button to both, stop transport and disarm the global record (if armed)

This is confusing, I would prefer a simple toggle behavior as it is on the track record functions.
BTW in the GUI, the stop button don’t disarm the global record and when the Transport/Record is used, it's only possible to disarm the recording when the transport is rolling. So no way to change your mind after you engage the record, you need ether take your mouse and disarm in the gui or hit play aud stop :( . In the practice, if your control surface is not near the workstation you gona need to leave your instrument and go to your screen, or play, stop, go back to your insertion point and begin again....
I don't know if it make sense for you ??

JaaxxOne

2012-07-01 20:28

reporter   ~0013759

Actually, this patch removes the "disable-rec on stop" behavior entirely and changes the rec binding from a function to an action "Transport/Record."

Unfortunately the loop function is broken in this map and others are inconsistent due to the way the Korg sends cc button messages. I've submitted another patch to correct both of these issues in issue 0004955

paul

2013-07-23 01:06

administrator   ~0015157

should be fixed as per related issue 0004955.

system

2020-04-19 20:16

developer   ~0023096

Issue has been closed automatically, by Trigger Close Plugin.
Feel free to re-open with additional information if you think the issue is not resolved.

Issue History

Date Modified Username Field Change
2012-06-26 03:26 JaaxxOne New Issue
2012-06-26 03:26 JaaxxOne File Added: nano_rec_fix.patch
2012-06-26 16:37 cth103 cost => 0.00
2012-06-26 16:37 cth103 Target Version => 3.0
2012-06-26 17:13 cth103 Note Added: 0013726
2012-06-26 17:13 cth103 Status new => resolved
2012-06-26 17:13 cth103 Resolution open => fixed
2012-06-26 17:13 cth103 Assigned To => cth103
2012-07-01 14:38 phdemartin Note Added: 0013758
2012-07-01 14:38 phdemartin Status resolved => assigned
2012-07-01 15:10 phdemartin Note Edited: 0013758
2012-07-01 20:28 JaaxxOne Note Added: 0013759
2013-07-23 01:05 paul Relationship added related to 0004955
2013-07-23 01:06 paul Note Added: 0015157
2013-07-23 01:06 paul Status assigned => resolved
2020-04-19 20:16 system Note Added: 0023096
2020-04-19 20:16 system Status resolved => closed