View Issue Details

IDCategoryLast Update
0007130bugs2016-11-21 23:40
ReportertimbyrAssigned Tonmains 
Reproducibilityalways 
Status resolvedResolutionfixed 
Product Version5.X git (version in description) 
Fixed in Version5.X git (version in description) 
Summary0007130: Incorrect ghost note displayed in percussive note mode
DescriptionIn percussive note mode the ghost note for sustained note mode is displayed.

It is correct I guess in that the note will be created at the position and length of the ghost note but it is confusing and not what I expect to be the correct behaviour in percussive mode.

My expectations are that when in draw mode with percussive note mode active, clicking will create a note at the closest snap/quantize point and that the new note will be displayed on mouse button press, not release wihtout the need for ghost notes. The length of the note should always be the length of the current quantize setting...I think.
TagsNo tags attached.

Relationships

related to 0007134 resolvedtimbyr Percussive MIDI Notes added by Draw Mode/Pencil Tool in single drag/operation should be a single Undo/Redo step 

Activities

nick_m

2016-11-20 17:06

reporter   ~0019011

Last edited: 2016-11-20 18:27

View 2 revisions

this should be fixed by e0c06f39e19

does it work as expected?

timbyr

2016-11-21 01:42

developer   ~0019015

Yes, the new behaviour is great. I have noticed two small issues though.

The first is in undo/redo entries are added per note addition in percussive mode when "brushing"/drawing in notes which I think you are aware of. It should be one entry for all notes added in one click/drag/release operation.

The other is that percussive/hit notes can be incorrectly inserted at the end of a region that are not played (or displayed in sustained mode).

If you have two midi regions adjacent to each other on a grid/quantize point then adding the note on the grid/snap point correctly places the note in the second region but if a region does not have a region adjacent to the end you can insert a note at the end.

nick_m

2016-11-21 16:58

reporter   ~0019019

the second issue should now be fixed.
display of hits/notes that start on the end of the region is now also prevented.
the undo issue is doable, but may have to wait.

timbyr

2016-11-21 23:40

developer   ~0019021

I'm marking this issue as resolved. Thanks a lot for implementing this fix/feature.

I've added the small issue with Undo/Redo as a feature enhancement, bug 7134

Issue History

Date Modified Username Field Change
2016-11-20 02:15 timbyr New Issue
2016-11-20 17:06 nick_m Note Added: 0019011
2016-11-20 18:27 nick_m Note Edited: 0019011 View Revisions
2016-11-21 01:42 timbyr Note Added: 0019015
2016-11-21 16:58 nick_m Note Added: 0019019
2016-11-21 23:38 timbyr Relationship added related to 0007134
2016-11-21 23:40 timbyr Note Added: 0019021
2016-11-21 23:40 timbyr Status new => resolved
2016-11-21 23:40 timbyr Fixed in Version => 5.X git (version in description)
2016-11-21 23:40 timbyr Resolution open => fixed
2016-11-21 23:40 timbyr Assigned To => nmains