|
2007-06-18 19:09
|
|
|
|
When I change a short 'clicking' crossfade into a full crossfade, the starting point stays where the starting point of the short crossfade was (at the end of the upper and earlier region), i.e., the crossfade spans a time interval with most of it outside the region. It sounds as if the fade-out would still be short, but the fade-in already full (but with wrong position). See also screenshot 'changing_short_crossfade_to_full.png'. |
|
2007-06-18 19:24
|
changing_short_crossfade_to_full.png (117,534 bytes) |
|
|
The click noise is not audible if the later region is higher (ardour 2.1). |
|
2008-02-11 04:48
|
export.wav (666,344 bytes) |
|
|
This bug seems to still exist in 2.7.1. See attached project "test" in crossfade_bug3.tgz, which was created from the scratch with ardour 2.7.1. The amplitude of the click depends on the signal, and is loudest when they have opposite sign. Probably one (last) sample from the first/top region is played before playing bottom region after crossfade. |
|
2008-12-11 21:17
|
|
|
2008-12-11 21:22
|
|
|
|
I can confirm this. I noticed that quite a while ago. |
|
|
Here is the source of the bug: In file crossfade.cc, function Crossfade::update() The lines case EndOfOut: _position = _out->last_frame() - _length; } should be case EndOfOut: _position = _out->last_frame() - _length + 1; } Otherwise _position will point to the last frame before the crossfade! This fix will not solve problems with invalid XML files. If the invalid position is stored there it will still click. I think this can be fixed by checking that the assumption /* precondition: caller has verified that we cover the desired section */ is correct. |
|
|
Assigned to Paul to take a quick look at the proposed fix. Seablade |
|
|
The solution mentioned above fixes only the problem described here, but I think there is a second of-by-one bug two lines above or below (I do not have ardour source code right now). Also the loading of sessions with the described problem will still produce clicks (because the method Crossfade::update() is not called from the XML constructor -- is there a possibility to emit an update signal in that constructor?). Giso |
|
|
please check rev 4720 - proposed fix(es) applied and committed. please let me know if this fixes the problem for you. |
|
|
Issue has been closed automatically, by Trigger Close Plugin. Feel free to re-open with additional information if you think the issue is not resolved. |
- Anonymous
