View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0001571 | ardour | bugs | public | 2007-03-22 11:03 | 2008-11-21 00:31 |
| Reporter | puddingpimp | Assigned To | paul | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Summary | 0001571: Clicking ruler while auditioning leaves transport controls disabled | ||||
| Description | Transport controls are not re-enabled when audition is cancelled by clicking ruler. I have included a patch, which calls session->cancel_audition() when left clicking the ruler if session->is_auditioning() is true. Base on other occurences where cancelling audition does work eg. from the Transport dropdown menu, by clicking play or stop. I forfeit any copyright and disclaim all warranty on the attached patch. Use as you see fit. | ||||
| Additional Information | From svn revision 1633. Steps to reproduce: Double-click region from right-hand region list Auditioning begins, transport toolbar is greyed out. Click timeline ruler Auditioning halts, transport is still greyed out. | ||||
| Tags | No tags attached. | ||||
|
2007-03-22 11:03
|
ardour2-cancel-audition-for-ruler.patch (463 bytes)
Index: editor_rulers.cc
===================================================================
--- editor_rulers.cc (revision 1633)
+++ editor_rulers.cc (working copy)
@@ -151,6 +151,11 @@
switch (ev->button) {
case 1:
+ // Since we are about to move the playhead, cancel any running
+ // auditions.
+ if (session->is_auditioning()) {
+ session->cancel_audition ();
+ }
/* transport playhead */
snap_to (where);
session->request_locate (where);
|
|
|
applied, but i saw your comments about the need for a central solution, and i agree. i'll put something inside the session locate code. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2007-03-22 11:03 | puddingpimp | New Issue | |
| 2007-03-22 11:03 | puddingpimp | File Added: ardour2-cancel-audition-for-ruler.patch | |
| 2007-03-22 14:52 | oofus | Relationship added | related to 0001524 |
| 2007-04-06 12:11 | paul | Status | new => resolved |
| 2007-04-06 12:11 | paul | Resolution | open => fixed |
| 2007-04-06 12:11 | paul | Assigned To | => paul |
| 2007-04-06 12:11 | paul | Note Added: 0003718 | |
| 2008-11-21 00:31 | seablade | Status | resolved => closed |
