View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0001524 | ardour | bugs | public | 2007-03-03 00:32 | 2007-04-06 22:09 |
| Reporter | oofus | Assigned To | paul | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Platform | Centrino 1.6GHz Laptop | OS | Linux | OS Version | Mandriva 2007 |
| Summary | 0001524: Moving the playhead during an audition locks out the transport keys. | ||||
| Description | Place the mouse over a region, press the audition key (/, ?). The region starts to playback and the transport keys are locked. Move the playhead to ... anywhere. The audition stops but the transport keys don't unlock. Auditioning another region and then cancelling it by clicking on the flashing 'Audition' button puts everything back to normality. | ||||
| Tags | No tags attached. | ||||
|
|
How do you move the playhead while auditioning? I encountered this problem when I moved the playhead by clicking in the ruler, and have submitted a patch in bug 0001571. Is there another way to move the playhead while in audition mode? If so, let me know. |
|
|
while the 'audition' button is flashing, click and drag on the red triangle at the top of the playhead. As soon as the playhead is moved the transport keys go blank and I haven't found a way to revert it. |
|
2007-03-24 00:17
|
audition.patch (483 bytes)
Index: gtk2_ardour/editor_mouse.cc
===================================================================
--- gtk2_ardour/editor_mouse.cc (revision 142)
+++ gtk2_ardour/editor_mouse.cc (working copy)
@@ -1922,7 +1922,11 @@
if (session && drag_info.was_rolling) {
session->request_stop ();
- }
+ }
+
+ if (session && session->is_auditioning()) {
+ session->cancel_audition ();
+ }
}
drag_info.pointer_frame_offset = drag_info.grab_frame - cursor->current_frame;
|
|
|
Hi, This looks like a similar problem 1571. The attached patch should fix it; would you like to test? Thanks for the report. Carl |
|
|
Patch tested. Yep, that seems to work for me. Thanks. |
|
|
...works here good too! cheers, doc |
|
|
cth103 If I am not mistaken, both this patch and the one I contributed in 1571 are necessary. I'm not sure if the code could be refactored so that any changes to the play-head location check and (if necessary) cancel auditioning. I'm not too familiar with the code-base right now. At the moment it seems like there needs to be an audition check in each place that the play-head can be moved. I think these are the only two places (please correct me if I'm wrong), as the transport toolbar is greyed out, and the menu options already cancel audition mode. |
|
|
patch applied. thanks carl. |
|
|
Tested. Fixed. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2007-03-03 00:32 | oofus | New Issue | |
| 2007-03-22 14:52 | oofus | Relationship added | related to 0001571 |
| 2007-03-22 20:29 | puddingpimp | Note Added: 0003643 | |
| 2007-03-22 22:40 | oofus | Note Added: 0003644 | |
| 2007-03-24 00:17 | cth103 | File Added: audition.patch | |
| 2007-03-24 00:18 | cth103 | Note Added: 0003650 | |
| 2007-03-24 00:18 | cth103 | Status | new => feedback |
| 2007-03-24 01:01 | oofus | Note Added: 0003651 | |
| 2007-03-24 19:08 | nowhiskey | Note Added: 0003652 | |
| 2007-03-27 04:26 | puddingpimp | Note Added: 0003671 | |
| 2007-04-06 12:07 | paul | Status | feedback => resolved |
| 2007-04-06 12:07 | paul | Resolution | open => fixed |
| 2007-04-06 12:07 | paul | Assigned To | => paul |
| 2007-04-06 12:07 | paul | Note Added: 0003717 | |
| 2007-04-06 22:09 | oofus | Status | resolved => closed |
| 2007-04-06 22:09 | oofus | Note Added: 0003732 |
