MantisBT

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0006677ardourbugspublic2015-11-17 09:152016-02-22 03:44
ReporterEbardie 
Assigned Totimbyr 
PrioritynormalSeverityminorReproducibilityalways
StatusresolvedResolutionfixed 
PlatformUbuntu VividOSLinuxOS Version3.19.0-32-lowlat
Product Version4.4 
Target VersionFixed in Version4.7 
Summary0006677: Post-export script reinterprets timestamp format placeholder giving incorrect filename
DescriptionI'm running a script after exporting a track.

The exported file includes an hours-and-minutes timestamp:

  IDWTLTY_session_2015-11-17_1631.flac


The basename format placeholder (%b) of the output file is passed to my script as:

  IDWTLTY_session_2015-11-17_1633

Note that this is over a minute after the exported filename.

This is a problem when the exported filename is needed in the post-export script.

Does this indicates that the %b is being regenerated after the file has been exported?




  
Steps To ReproduceExport at file that takes longer than a minute to process, with the exported filename set to include the hour-and-minute timestamp, and Export Format Profile's Command to run post-export set to:

  /usr/bin/xterm -hold -e bash -c "echo "%b

Compare the displayed basename with the exported filename.

TagsNo tags attached.
Attached Filespatch file icon fix-6677.patch [^] (1,382 bytes) 2016-01-12 19:29 [Show Content]
patch file icon fix-6677-good.patch [^] (1,499 bytes) 2016-01-13 02:40 [Show Content]

- Relationships
related to 0006713resolvedtimbyr Name of Audio (timestamp) does not match with written Filename in CD-Cue file 

-  Notes
(0017778)
elgoun (reporter)
2016-01-12 19:28

The problem is due to the localtime function and her statically allocated buffer in ExportFilename class.

time_struct variable is set once at construct time, but her value change over time.

Attached a fix that solves the problem.
(0017779)
elgoun (reporter)
2016-01-13 02:40
edited on: 2016-01-13 02:51

My first patch is not good.

I saw it after, but there is an implementation of localtime_r in pbd for systems that don't have localtime_r.Futhermore my call to localtime_s (for windows) is bad.

Attached a new patch which is correct (I hope ;-)

It fix 6713 too.

(0017925)
timbyr (developer)
2016-02-12 19:09

This issue should now be fixed in ardour master as of revision a3dd27c41b or in a nightly build >= 4.6.332

Can you please test and confirm, thanks.

- Issue History
Date Modified Username Field Change
2015-11-17 09:15 Ebardie New Issue
2016-01-12 19:28 elgoun Note Added: 0017778
2016-01-12 19:29 elgoun File Added: fix-6677.patch
2016-01-13 02:28 colinf Relationship added related to 0006713
2016-01-13 02:40 elgoun Note Added: 0017779
2016-01-13 02:40 elgoun File Added: fix-6677-good.patch
2016-01-13 02:51 elgoun Note Edited: 0017779 View Revisions
2016-02-12 19:09 timbyr Note Added: 0017925
2016-02-12 19:09 timbyr Assigned To => timbyr
2016-02-12 19:09 timbyr Status new => feedback
2016-02-22 03:44 timbyr Status feedback => resolved
2016-02-22 03:44 timbyr Fixed in Version => 4.7
2016-02-22 03:44 timbyr Resolution open => fixed


Copyright © 2000 - 2018 MantisBT Team
Powered by Mantis Bugtracker