|Anonymous | Login | Signup for a new account||2018-12-15 09:52 PST|
|My View | View Issues | Change Log | Roadmap|
|View Issue Details|
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0006677||ardour||bugs||public||2015-11-17 09:15||2016-02-22 03:44|
|Platform||Ubuntu Vivid||OS||Linux||OS Version||3.19.0-32-lowlat|
|Target Version||Fixed in Version||4.7|
|Summary||0006677: Post-export script reinterprets timestamp format placeholder giving incorrect filename|
|Description||I'm running a script after exporting a track.|
The exported file includes an hours-and-minutes timestamp:
The basename format placeholder (%b) of the output file is passed to my script as:
Note that this is over a minute after the exported filename.
This is a problem when the exported filename is needed in the post-export script.
Does this indicates that the %b is being regenerated after the file has been exported?
|Steps To Reproduce||Export at file that takes longer than a minute to process, with the exported filename set to include the hour-and-minute timestamp, and Export Format Profile's Command to run post-export set to:|
/usr/bin/xterm -hold -e bash -c "echo "%b
Compare the displayed basename with the exported filename.
|Tags||No tags attached.|
|Attached Files|| fix-6677.patch [^] (1,382 bytes) 2016-01-12 19:29 [Show Content]
fix-6677-good.patch [^] (1,499 bytes) 2016-01-13 02:40 [Show Content]
The problem is due to the localtime function and her statically allocated buffer in ExportFilename class.
time_struct variable is set once at construct time, but her value change over time.
Attached a fix that solves the problem.
edited on: 2016-01-13 02:51
My first patch is not good.
I saw it after, but there is an implementation of localtime_r in pbd for systems that don't have localtime_r.Futhermore my call to localtime_s (for windows) is bad.
Attached a new patch which is correct (I hope ;-)
It fix 6713 too.
This issue should now be fixed in ardour master as of revision a3dd27c41b or in a nightly build >= 4.6.332
Can you please test and confirm, thanks.
|2015-11-17 09:15||Ebardie||New Issue|
|2016-01-12 19:28||elgoun||Note Added: 0017778|
|2016-01-12 19:29||elgoun||File Added: fix-6677.patch|
|2016-01-13 02:28||colinf||Relationship added||related to 0006713|
|2016-01-13 02:40||elgoun||Note Added: 0017779|
|2016-01-13 02:40||elgoun||File Added: fix-6677-good.patch|
|2016-01-13 02:51||elgoun||Note Edited: 0017779||View Revisions|
|2016-02-12 19:09||timbyr||Note Added: 0017925|
|2016-02-12 19:09||timbyr||Assigned To||=> timbyr|
|2016-02-12 19:09||timbyr||Status||new => feedback|
|2016-02-22 03:44||timbyr||Status||feedback => resolved|
|2016-02-22 03:44||timbyr||Fixed in Version||=> 4.7|
|2016-02-22 03:44||timbyr||Resolution||open => fixed|
|Copyright © 2000 - 2018 MantisBT Team|