MantisBT

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0004875ardourbugspublic2012-05-13 02:272012-05-21 02:22
Reporterelfring 
Assigned Topaul 
PrioritynormalSeverityminorReproducibilityalways
StatusresolvedResolutionwon't fix 
PlatformOSOS Version
Product Version 
Target Version3.XFixed in Version 
Summary0004875: reserved identifier violation
DescriptionI would like to point out that identifiers like "__ardour_amp_h__" and "_AlignStyle" do not fit to the expected naming convention of the C++ language standard.
http://viewcvs.ardour.org/index.cgi/ardour2/ardour2/branches/3.0/libs/ardour/ardour/amp.h?revision=11535&view=markup [^]
http://viewcvs.ardour.org/index.cgi/ardour2/ardour2/branches/3.0/libs/ardour/enums.cc?revision=12253&view=markup [^]

Would you like to adjust your selection for unique names?
Additional Informationhttps://www.securecoding.cert.org/confluence/display/cplusplus/DCL32-CPP.+Do+not+declare+or+define+a+reserved+identifier [^]
TagsNo tags attached.
Attached Files

- Relationships

-  Notes
(0013269)
paul (administrator)
2012-05-21 02:22

We will accept patches for this but I consider the language standard hopelessly at odds with (a) common C and C++ programming habits over the last 30 years and (b) a probabilistic assessment of reality.

The chances of a compiler or another library definining __ardour_amp_h__ are vanishingly small. The chances of a compiler or another library defining an identifier with function scope and a name like _AlignStyle are even smaller.

Ardour's code is definitely not in line with the standard, but I am going to mark this as WONTFIX. Patches to change things will be cheerfully accepted.

- Issue History
Date Modified Username Field Change
2012-05-13 02:27 elfring New Issue
2012-05-13 05:25 cth103 cost => 0.00
2012-05-13 05:25 cth103 Severity major => minor
2012-05-13 05:25 cth103 Status new => confirmed
2012-05-13 05:25 cth103 Target Version => 3.X
2012-05-21 02:22 paul Note Added: 0013269
2012-05-21 02:22 paul Status confirmed => resolved
2012-05-21 02:22 paul Resolution open => won't fix
2012-05-21 02:22 paul Assigned To => paul


Copyright © 2000 - 2018 MantisBT Team
Powered by Mantis Bugtracker