View Issue Details

IDProjectCategoryView StatusLast Update
0004414ardourbugspublic2015-09-18 15:11
Reportercolinf Assigned Tocth103  
PrioritynormalSeverityminorReproducibilitysometimes
Status closedResolutionfixed 
Target Version3.0-beta1 
Summary0004414: 'Rename' in processor box context menu is not always enabled & disabled correctly
DescriptionThe 'Rename' item in the processor box is not always enabled & disabled correctly.

I assume that the intended behaviour is that plugins, external sends, and inserts can be renamed, but internal sends and the channel fader cannot. However, this isn't always the case in practice.
Additional InformationSteps to reproduce:

 * Create a new project with two tracks and a bus.
 * Open the mixer window.
 * Add a plugin and an aux send to each track.
 * left-click on the plugin in track 1 to select it
 * left-click on the send in track 2 to select it
 * right-click the plugin in track 1. 'Rename' appears disabled, though it should be enabled.
 * left-click the send in track 1.
 * right-click the plugin in track 1. 'Rename' is now enabled.
 * right-click the send in track 2. 'Rename' remains enabled.

What I think is happening is that right-clicks in an already-selected plugin or send of a track that is not currently selected are not causing ProcessorBox::selection_changed() to be called, so the menu item sensitivity is not being updated correctly.
TagsNo tags attached.

Activities

colinf

2011-11-07 17:36

updater   ~0011929

Incidentally, what's the rationale behind deciding which things in the processor box can be renamed? 'Rename' seems to work on all of them, even those for which it seems it's intended to be disabled, so maybe the simplest fix for this is for 'Rename' to always be enabled.

cth103

2011-11-08 14:44

administrator   ~0011951

Should be fixed up in SVN 10495. Commenting in bug 0003048, Paul said that plugins should not be rename-able.

colinf

2015-09-18 15:11

updater   ~0017243

Closing old issues: these have long since been fixed.

Issue History

Date Modified Username Field Change
2011-10-31 12:56 colinf New Issue
2011-10-31 14:06 cth103 cost => 0.00
2011-10-31 14:06 cth103 Target Version => 3.0-beta1
2011-11-07 17:36 colinf Note Added: 0011929
2011-11-08 14:44 cth103 Note Added: 0011951
2011-11-08 14:44 cth103 Status new => resolved
2011-11-08 14:44 cth103 Resolution open => fixed
2011-11-08 14:44 cth103 Assigned To => cth103
2015-09-18 15:11 colinf Note Added: 0017243
2015-09-18 15:11 colinf Status resolved => closed