View Issue Details

IDProjectCategoryView StatusLast Update
0004257ardourbugspublic2020-04-19 20:15
Reporterin0giro Assigned Tocth103  
PrioritynormalSeveritymajorReproducibilityalways
Status closedResolutionfixed 
PlatformIntel Core2 DuoOSGentoo amd64 + Pro-Audio overlayOS Versionstable
Target Version3.0 
Summary0004257: tempo changes cause MIDI region edits to not work as expected
Descriptionwhen a tempo change is present in a session when MIDI regions are recorded and edited, or added to a session with existing recorded MIDI regions, MIDI region editing, such as splits, does not work as expected. often, the visual notes in the latest (right most) region will shift towards the right, but the region will play correctly. also, moving a newly created region from a split (when not even intersecting the tempo change) will cause its notes to shift/change in the region. finally, sometimes even adding a tempo change cause MIDI regions to move along timeline, notes to change, etc.

this bug effectively prevents any reliable MIDI region editing with a session containing tempo changes.
Steps To Reproduce1. open session
2. add audio bus
3. add MIDI track, and wire external JACK synth MIDI in from MIDI track's out, and audio out from external JACK synth to audio bus in
4. add second audio out port on audio bus and wire bus audio out to master audio in
5. insert tempo change @bar 4
6. record MIDI region in bars before bar 4
7. split MIDI region MIDI-1 @bar 2

note the notes at the end of the region move towards the region end, though region plays fine

8. make a split of MIDI region MIDI-1.13 @bar 3

note how the notes in MIDI-1.15 (now) move forward in time again, though region plays fine

this scenario is shown in attachment "A3 MIDI region split test [2011.08.10.17.05].tag.gz"


an alternative is to create a new session, record a MIDI region, split it, then add a tempo change after the MIDI regions. the MIDI regions will move and change just with the addition of the tempo change.

this scenario is shown in attachment "A3 MIDI region split test (no initial tempo change) [2011.08.10.17.55].tag.gz"
Additional InformationNOTE: the tempo change does not even have to intersect the MIDI region(s) in question to cause this bug, and i usually place it later in the time line to avoid any intersection.

NOTE: i tried this in a new session with MIDI regions and no tempo change,
Tags3.0, Midi, region, split, tempo change

Activities

2011-08-10 22:23

 

2011-08-10 22:23

 

paul

2011-08-16 14:25

administrator   ~0011360

rev 9998 should have a beneficial effect on this issue. it may have some side effects, possibly bad.

in0giro

2011-08-18 14:49

reporter   ~0011371

the changes have helped a bit: splits with a tempo change present in the timeline, but not intersecting the region being split, now seem to work better (see issue 1 below). but there are still major issues, though some may depend on IF i am understanding how MIDI should behave, with/without tempo changes (mainly #3).

issue 1: record a new MIDI region in a new session, no tempo changes, say 0000014:0000007 bars long, leaving space (i.e. no notes) at each first beat. insert a split at bar 2 beat 1 (not intersecting any notes) and watch how some notes after the split move *slightly*, some forward, some backward. you can use undo/redo to notice the changes. the audible difference is not really noticeable at 120 BPMs, but they are visibly moving. this happens whether there is a tempo change present (not intersecting) in the session or not.

issue 2: record a new MIDI region in a new session, no tempo changes in session yet. then make a split in the region. finally, add a tempo change *after* the end of the regions. note how the new region created by the split (right side) moves drastically/incorrectly when the tempo change is added. this happens no matter where the tempo change is inserted (i.e. intersecting either region or neither).

issue 3: when copying/moving a region from one tempo to another in a session, the region notes seemed to be altered correctly, and the copied region itself is also stretched, but notes' starting points are moved in ways that seem inconsistent. example: a MIDI region in a tempo of 120 BPM 4/4 has a note starting on the first beat of a bar, the note is 1 bar/4 beats long, and the region is 1 bar long. when copied to another slower tempo (80 BPM) further down the timeline, but still starting at beat 1 of a bar, the note is stretched to still be 1 bar long, but now it is starting on the 3rd beat of the bar, though i assume it should start at the 1st still. furthermore, moving that region so that the note starts with the first beat as it should (still after the tempo change), the note moves backward too much, and constantly trying to adjust the region position results in the note continually moving back and forth.

these are the 3 biggest issues i am still seeing with MIDI and tempo changes. perhaps these should be in their own bug reports? let me know and i will add them separately.

in0giro

2011-08-18 14:50

reporter   ~0011372

the above note is referring to rev. 10002

cth103

2011-12-11 21:36

administrator   ~0012379

I'm pretty sure issue 1 is visual only, it's a pixel rounding thing that is probably quite gnarly because gnomecanvas is involved.

Issue 2 confirmed, region BBT times aren't set on split.

cth103

2011-12-12 02:50

administrator   ~0012390

Issue 2 should be fixed in SVN 10986.

in0giro

2011-12-12 22:31

reporter   ~0012394

issue 2 seems to be fixed in SVN 10991.

issue 1 being a visual rounding thing would make sense, as even at slow tempos (0000009:0000010) i cannot hear an audible difference. however, it is disconcerting to see the notes move on a simple region split, "just in case" they are actually being changed. perhaps this should be its own bug for later? i can file this if necessary.

thanks.

cth103

2012-04-25 17:21

administrator   ~0013190

Added issue 1 as a new report 0004853.

system

2020-04-19 20:15

developer   ~0022711

Issue has been closed automatically, by Trigger Close Plugin.
Feel free to re-open with additional information if you think the issue is not resolved.

Issue History

Date Modified Username Field Change
2011-08-10 22:23 in0giro New Issue
2011-08-10 22:23 in0giro File Added: A3 MIDI region split test [2011.08.10.17.05].tar.bz2
2011-08-10 22:23 in0giro File Added: A3 MIDI region split test (no initial tempo change) [2011.08.10.17.55].tar.bz2
2011-08-10 22:24 in0giro Tag Attached: 3.0
2011-08-10 22:24 in0giro Tag Attached: Midi
2011-08-10 22:24 in0giro Tag Attached: region
2011-08-10 22:24 in0giro Tag Attached: split
2011-08-10 22:24 in0giro Tag Attached: tempo change
2011-08-12 15:59 cth103 cost => 0.00
2011-08-12 15:59 cth103 Target Version => 3.0-beta1
2011-08-16 14:25 paul Note Added: 0011360
2011-08-16 17:56 paul Status new => feedback
2011-08-18 14:49 in0giro Note Added: 0011371
2011-08-18 14:50 in0giro Note Added: 0011372
2011-11-15 15:57 cth103 Target Version 3.0-beta1 => 3.0-beta2
2011-12-11 21:36 cth103 Note Added: 0012379
2011-12-12 02:50 cth103 Note Added: 0012390
2011-12-12 22:31 in0giro Note Added: 0012394
2012-01-10 20:45 cth103 Target Version 3.0-beta2 => 3.0-beta3
2012-02-14 17:20 paul Target Version 3.0-beta3 => 3.0 beta4
2012-04-23 22:07 cth103 Status feedback => acknowledged
2012-04-25 17:21 cth103 Note Added: 0013190
2012-04-25 17:21 cth103 Status acknowledged => resolved
2012-04-25 17:21 cth103 Resolution open => fixed
2012-04-25 17:21 cth103 Assigned To => cth103
2012-05-23 15:07 cth103 Target Version 3.0 beta4 => 3.0
2020-04-19 20:15 system Note Added: 0022711
2020-04-19 20:15 system Status resolved => closed