MantisBT

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0003884ardourbugspublic2011-03-25 11:282015-09-18 08:14
Reportercolinf 
Assigned Topaul 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target Version3.XFixed in Version 
Summary0003884: Freesound tab doesn't appear in 'Import' dialog
DescriptionI built A3 with Freesound, but there's no sign of the 'Freesound' tab in the 'Import' dialog.

In fact, I don't think FREESOUND is defined for compilation at all.
TagsNo tags attached.
Attached Filespatch file icon freesound-new-api-10499.patch [^] (37,904 bytes) 2011-11-08 10:52 [Show Content]
patch file icon freesound-new-api-10577.patch [^] (37,870 bytes) 2011-11-14 03:39 [Show Content]
patch file icon freesound-2011-12-08.patch [^] (7,862 bytes) 2011-12-08 14:23 [Show Content]

- Relationships

-  Notes
(0010413)
paul (administrator)
2011-03-25 13:04

FreeSound support is broken now that FreeSound has moved to their new API (which looks as if it might actually work, unlike the old one). FreeSound support will not return until someone volunteers to port the code over to their new API.
(0011923)
colinf (updater)
2011-11-06 15:52

I've had a play with the new Freesound API this weekend, and I'm hopeful that making this work might actually be within my capabilities. Patch to follow soonish.
(0011954)
colinf (updater)
2011-11-08 11:02
edited on: 2011-11-08 11:09

I've attached my current attempt at making this work, just so it's backed up somewhere in case my computer is struck by lightning or something.

There are still plenty of rough edges, and I haven't taken advantage of any of the nice stuff that the new Freesound API offers. However, I think it works more-or-less as well as the old Freesound support ever did.

bugs/wrinkles still remaining:
 - make the displayed data in the freesound tab more useful (we don't need to show the uri to users).
 - sort out oddities with the ProgressBar. It probably needs to be made properly thread-safe: I don't know what happens inside libcurl.
 - the progress bar is also rather arbitrarily placed in the window at the moment: it could probably be put somewhere more logical and/or nicer-looking.
 - sound file info sometimes doesn't get updated on the first click.
 - add a means of cancelling sound file downloads.
 - it uses an API key I registered myself (under an application name of 'test' and with my web site url): I guess someone will need to register a key (or keys) for Ardour. I'm happy to do this, but it might make more sense to do it through a freesound account accessible to one or more main developers.
 - loads of unnecessarily verbose debug output.
 - probably plenty more things wrong.

(0011959)
paul (administrator)
2011-11-09 03:16

can i apply this? it contains your freesound credentials...
(0011963)
colinf (updater)
2011-11-09 04:42

I suppose Ardour ought to have its own API key: do you have a Freesound account to create one, or should there be an Ardour account too?
(0011964)
paul (administrator)
2011-11-09 04:46

i thought the idea was the user logged in themselves?
(0011965)
colinf (updater)
2011-11-09 07:16

You may be right: the Freesound web site developer help just says "In order to use the Freesound API you need to be authenticated with an API key", but it's a bit ambiguous whether "use" means writing or running code that uses the API. I'll go & have another read & see if it's made any clearer anywhere else.
(0011971)
colinf (updater)
2011-11-10 05:50

Looking at various messages in the Freesound google group, it seems that API keys are 'per-application', not 'per-user', so I guess that Ardour will need one. Shall I apply for one, or will you?

http://groups.google.com/group/freesound-api/browse_thread/thread/027bb502268cac56# [^]
http://groups.google.com/group/freesound-api/browse_thread/thread/9c4280e7bb9df8e8# [^]
(0011972)
paul (administrator)
2011-11-10 06:01

colin - it would be great if you could take care of this. thanks.
(0011991)
colinf (updater)
2011-11-14 03:44

New version of patch uploaded, the same as the previous except that the API key is now one I've created for Ardour 3. In fact, I registered ardour3 as a Freesound user and created the API key from that account: I hope that was a sensible thing to do.

I hope I'll have a few moments this week to polish some of the other rough edges, but I'm very happy if you want to apply this version in the meanwhile.
(0012019)
paul (administrator)
2011-11-14 14:08

committed in rev 10596
(0012328)
colinf (updater)
2011-12-08 14:33

Attached a patch (freesound-2011-12-08.patch) to address a (very) few of the outstanding annoyances with this. The patch:
 * adds a 'Stop' button.
 * ups the curl timeout to 30 seconds so it now works via my GPRS phone.
 * clears the progress bar barbershop pole pattern after a sound file download (in a very hackish way: sorry).
 * removes the display of the URI in the listbox: only the ID and the file name are displayed now. Maybe some other information could be added, e.g. length, sample rate, &c., if anyone thinks this might be useful.
(0012567)
paul (administrator)
2012-01-18 10:43

2011-12-08 patched committed in rev 11265
(0012590)
paul (administrator)
2012-01-20 03:19

I'm going to close this bug for now because of the title. I'm sure there are some more issues to be addressed with freesound support, but lets open new bugs for them.
(0017262)
colinf (updater)
2015-09-18 08:14

Closing old issues reported by me: these have long since been fixed.

- Issue History
Date Modified Username Field Change
2011-03-25 11:28 colinf New Issue
2011-03-25 11:35 cth103 cost => 0.00
2011-03-25 11:35 cth103 Target Version => 3.0-beta1
2011-03-25 13:04 paul Note Added: 0010413
2011-03-25 13:04 paul Status new => confirmed
2011-04-18 16:22 cth103 Target Version 3.0-beta1 => 3.X
2011-11-06 15:52 colinf Note Added: 0011923
2011-11-08 10:52 colinf File Added: freesound-new-api-10499.patch
2011-11-08 11:02 colinf Note Added: 0011954
2011-11-08 11:07 colinf Note Edited: 0011954
2011-11-08 11:09 colinf Note Edited: 0011954
2011-11-09 03:16 paul Note Added: 0011959
2011-11-09 03:16 paul Status confirmed => assigned
2011-11-09 03:16 paul Assigned To => paul
2011-11-09 04:42 colinf Note Added: 0011963
2011-11-09 04:46 paul Note Added: 0011964
2011-11-09 07:16 colinf Note Added: 0011965
2011-11-10 05:50 colinf Note Added: 0011971
2011-11-10 06:01 paul Note Added: 0011972
2011-11-14 03:39 colinf File Added: freesound-new-api-10577.patch
2011-11-14 03:44 colinf Note Added: 0011991
2011-11-14 14:08 paul Note Added: 0012019
2011-12-08 14:23 colinf File Added: freesound-2011-12-08.patch
2011-12-08 14:33 colinf Note Added: 0012328
2012-01-18 10:43 paul Note Added: 0012567
2012-01-20 03:19 paul Note Added: 0012590
2012-01-20 03:19 paul Status assigned => resolved
2012-01-20 03:19 paul Resolution open => fixed
2015-09-18 08:14 colinf Note Added: 0017262
2015-09-18 08:14 colinf Status resolved => closed


Copyright © 2000 - 2018 MantisBT Team
Powered by Mantis Bugtracker