View Issue Details

IDProjectCategoryView StatusLast Update
0003343ardourbugspublic2010-08-02 20:16
Reporteroofus Assigned Tocth103  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
PlatformDell D830 core2duo T9300 2.5GHzOSMandrivaOS Version2010
Target Version3.0-beta1 
Summary0003343: Using the track height buttons to make track heights smaller can cause tracks to be made smaller than the minimum allowable.
DescriptionUsing the track height buttons to make track heights smaller can cause tracks to be made smaller than the minimum allowable.

see attached screenshot.
Steps To ReproduceMake a session with 4 tracks. Set each of the tracks to a different height. Now use the track height button to make the track heights smaller. Keep on going until all tracks are as small as they can get.
TagsNo tags attached.

Activities

2010-07-20 15:08

 

track_heights.png (9,497 bytes)   
track_heights.png (9,497 bytes)   

2010-07-24 09:26

 

min_track_height_fix.patch (1,295 bytes)   
Index: gtk2_ardour/time_axis_view.cc
===================================================================
--- gtk2_ardour/time_axis_view.cc	(revision 7481)
+++ gtk2_ardour/time_axis_view.cc	(working copy)
@@ -396,36 +396,19 @@
 		if ( height == preset_height(HeightSmall)){
 			return;
 		}
-		if (height == preset_height (HeightSmaller)) {
+		
+		if (height <= preset_height (HeightSmaller) && height > preset_height (HeightSmall)) {
 			set_height (preset_height(HeightSmall));
 		}
-		else if (height > step) {	
-			
-			if ( height <= preset_height (HeightNormal) && height > preset_height (HeightSmaller)){
-				set_height (preset_height(HeightSmaller));
-			}
-			else {
-				set_height (height - step);
-			}
+		else if ( height <= preset_height (HeightNormal) && height > preset_height (HeightSmaller)){
+			set_height (preset_height(HeightSmaller));
+		}
+		else {
+			set_height (height - step);
 		} 
 	}
 }
-/*
-	switch (h) {
-	case HeightLargest:
-		return extra_height + 48 + 250;
-	case HeightLarger:
-		return extra_height + 48 + 150;
-	case HeightLarge:
-		return extra_height + 48 + 50;
-	case HeightNormal:
-		return extra_height + 48;
-	case HeightSmall:
-		return 27;
-	case HeightSmaller:
-		return smaller_height;
-	}
-*/
+
 void
 TimeAxisView::set_heights (uint32_t h)
 {
min_track_height_fix.patch (1,295 bytes)   

lincoln

2010-07-24 09:26

reporter   ~0008623

My bad. Attached patch fixes the issue.

cth103

2010-07-25 01:17

administrator   ~0008629

Patch applied to SVN. Thanks!

oofus

2010-08-02 20:16

developer   ~0008697

Fixed

Issue History

Date Modified Username Field Change
2010-07-20 15:08 oofus New Issue
2010-07-20 15:08 oofus File Added: track_heights.png
2010-07-20 16:19 cth103 cost => 0.00
2010-07-20 16:19 cth103 Target Version => 3.0-beta1
2010-07-24 09:26 lincoln File Added: min_track_height_fix.patch
2010-07-24 09:26 lincoln Note Added: 0008623
2010-07-25 01:17 cth103 Note Added: 0008629
2010-07-25 01:17 cth103 Status new => resolved
2010-07-25 01:17 cth103 Resolution open => fixed
2010-07-25 01:17 cth103 Assigned To => cth103
2010-08-02 20:16 oofus Note Added: 0008697
2010-08-02 20:16 oofus Status resolved => closed