View Issue Details

IDProjectCategoryView StatusLast Update
0002960ardourbugspublic2010-10-29 16:18
Reporteroofus Assigned Tocth103  
PrioritynormalSeveritymajorReproducibilitysometimes
Status closedResolutionfixed 
PlatformDell D830 core2duo T9300 2.5GHzOSMandrivaOS Version2009.1
Product VersionSVN/2.0-ongoing 
Target Version3.0-beta1 
Summary0002960: Split (S key) doesn't work first time when no region or track header is selected.
DescriptionSplit (S key) doesn't work first time when no region or track header is selected. Edit point is set to playhead. Sometimes, after a track header or a region is selected, splitting works with nothing selected.

I believe the expected behaviour is that all regions under the playhead should be split if nothing is selected.
TagsNo tags attached.

Activities

cth103

2009-12-18 18:44

administrator   ~0007246

What do you think should happen for split if nothing is selected and "mouse" is the edit point? Split the region under the mouse, or split every region that is at the same time as the mouse?

oofus

2009-12-18 19:35

developer   ~0007247

Hmm, for mouse most natural feels like only the region under the mouse, but that goes against what happens for playhead where every region at that time is split.

I think it should e consistent with playhead and do all regions at that time. Selecting a region or a track header would then just apply to that track or region.

There is a knock on with grouped tracks that have edit enabled as well I suppose.

cth103

2009-12-19 02:22

administrator   ~0007248

Yeah, it's tricky. My personal opinion is that splitting all regions in mouse mode would be really unexpected and generally bad. So, even though its inconsistent, I'm inclined to special-case mouse mode to operate only on the region under the mouse, and cut all regions if in playhead mode... any thoughts on that?

oofus

2009-12-19 10:51

developer   ~0007249

So that would mean :

Nothing selected - Split region under the mouse only.
n regions selected - split those regions if they are at mouse time.
n tracks selected - split regions on those tracks at mouse time.

but what to do here :

1) n regions selected, mouse pointing at a region that isn't selected ?
2) n track headers selected, mouse is pointing at a track that isn't selected ?
3) n regions and n tracks selected, mouse pointing at any of these selected things ?
4) n regions and n tracks selected, mouse not pointing at any of these selected items ?

cth103

2010-09-28 23:32

administrator   ~0009190

I'm inclined to say that 'S' operates on regions, not tracks, so track selection should not influence things. Selected region behaviour is trickier; my first instinct would be to split the region under the mouse and any selected regions. Any thoughts about that?

lincoln

2010-10-06 22:53

reporter   ~0009212

I tend to agree with cth103 here, mouse edit point is very contextual and tracks should not play a part in what is hit by a split.

I would say if you select n regions and split anyone of the selected regions, n regions get split (if they happen to cover the split point).

If you select n regions then split a non selected region, you discard the selection and operate on the region under the mouse.

Multi region splits are probably better performed with the range mode in most situations, or the playhead edit mode. Mouse edit point is very specific.

oofus

2010-10-17 12:36

developer   ~0009244

On reflection I think I agree as well, mouse edit is quite specific. I can see leaving more general things to, say, playhead edit mode. I can see wanting to place the playhead, select some tracks and have the split happen on those selected tracks.

So, mouse mode only works on regions, ignore track selections. if you point at a selected region split it and any other regions that are selected. If you point at an unselected region cancel any other region selections and split that newly selected region. If you point at empty space do nothing.

I think that covers it, although I am just re-stating what lincoln said :)

cth103

2010-10-19 22:10

administrator   ~0009283

Fixed in SVN, I believe.

oofus

2010-10-29 16:18

developer   ~0009323

see notes

Issue History

Date Modified Username Field Change
2009-12-16 19:47 oofus New Issue
2009-12-18 18:44 cth103 Note Added: 0007246
2009-12-18 18:44 cth103 Status new => feedback
2009-12-18 19:35 oofus Note Added: 0007247
2009-12-19 02:22 cth103 Note Added: 0007248
2009-12-19 10:51 oofus Note Added: 0007249
2010-04-24 10:28 cth103 Category bugs => bugs2
2010-04-24 10:31 cth103 Category bugs2 => bugs
2010-07-22 15:26 oofus cost => 0.00
2010-07-22 15:26 oofus Target Version => 3.0-beta1
2010-09-28 23:32 cth103 Note Added: 0009190
2010-10-06 22:53 lincoln Note Added: 0009212
2010-10-17 12:36 oofus Note Added: 0009244
2010-10-19 22:10 cth103 Note Added: 0009283
2010-10-19 22:10 cth103 Status feedback => resolved
2010-10-19 22:10 cth103 Resolution open => fixed
2010-10-19 22:10 cth103 Assigned To => cth103
2010-10-29 16:18 oofus Note Added: 0009323
2010-10-29 16:18 oofus Status resolved => closed