View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002378 | ardour | bugs | public | 2008-08-27 01:34 | 2020-04-19 20:13 |
| Reporter | sm4tik | Assigned To | paul | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | SVN/2.0-ongoing | ||||
| Summary | 0002378: [PATCH] Ardour refuses to build with NLS=no | ||||
| Description | When building ardour with NLS disabled, the file gtk2_ardour/new_session_dialog.cc gives a build error. After searching for related issues, I found the order of #included files to be the reason. Here's a patch included which fixed it atleast for me. Building tested with ardour2.5 and 2.X svn. | ||||
| Tags | No tags attached. | ||||
|
2008-08-27 01:34
|
disable_nls.patch (484 bytes)
--- gtk2_ardour/new_session_dialog.cc.orig 2008-08-27 03:04:43.000000000 +0300
+++ gtk2_ardour/new_session_dialog.cc 2008-08-27 00:20:16.000000000 +0300
@@ -17,9 +17,6 @@
*/
-#include "i18n.h"
-#include "new_session_dialog.h"
-
#include <pbd/error.h>
#include <ardour/recent_sessions.h>
@@ -43,6 +40,8 @@
#include "opts.h"
#include "utils.h"
+#include "i18n.h"
+#include "new_session_dialog.h"
NewSessionDialog::NewSessionDialog()
: ArdourDialog ("session control")
|
|
|
Assigning to Paul in case he wants to include this patch in a 2.X release. Thanks! |
|
|
This patch was applied somewhere around rev 4288 :) |
|
|
Issue has been closed automatically, by Trigger Close Plugin. Feel free to re-open with additional information if you think the issue is not resolved. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2008-08-27 01:34 | sm4tik | New Issue | |
| 2008-08-27 01:34 | sm4tik | File Added: disable_nls.patch | |
| 2010-04-24 10:28 | cth103 | Category | bugs => bugs2 |
| 2010-04-24 10:32 | cth103 | Category | bugs2 => bugs |
| 2010-04-26 22:02 | cth103 | Status | new => assigned |
| 2010-04-26 22:02 | cth103 | Assigned To | => paul |
| 2010-04-26 22:02 | cth103 | cost | => 0.00 |
| 2010-04-26 22:02 | cth103 | Summary | Ardour refuses to build with NLS=no => [PATCH] Ardour refuses to build with NLS=no |
| 2010-04-26 22:03 | cth103 | Note Added: 0007601 | |
| 2010-04-27 13:40 | paul | Note Added: 0007630 | |
| 2010-04-27 13:40 | paul | Status | assigned => resolved |
| 2010-04-27 13:40 | paul | Resolution | open => fixed |
| 2020-04-19 20:13 | system | Note Added: 0021784 | |
| 2020-04-19 20:13 | system | Status | resolved => closed |
