View Issue Details

IDProjectCategoryView StatusLast Update
0002363ardourbugspublic2020-04-19 20:13
Reporterbennyp Assigned Topaul  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product VersionSVN/2.0-ongoing 
Summary0002363: "Name New Markers" Behaviors Inconsistent
DescriptionDear Developers,

The new (and very convenient) "Name New Markers" feature is nice to have, but it does not consistently work according to it's menu option/toggle.

Often in a new session, even though the option to have new markers named is untoggled, any new markers I create will cause a name dialogue to pop up.

After toggling the menu and detoggling again, it seems to work as expected.

I've tried it twice, same results.

Thanks!
TagsNo tags attached.

Activities

colinf

2008-07-31 18:09

updater   ~0005125

Ah, OK. The value of "Name New Markers" is stored in the session file, but the menu tick mark isn't updated when the session is loaded.

I think the attached patch should help...

2008-07-31 18:09

 

name-new-markers-state.patch (757 bytes)   
Index: gtk2_ardour/ardour_ui_options.cc
===================================================================
--- gtk2_ardour/ardour_ui_options.cc	(revision 3650)
+++ gtk2_ardour/ardour_ui_options.cc	(working copy)
@@ -1213,6 +1213,8 @@
 		editor->toggle_meter_updating();
 	} else if (PARAM_IS ("default-narrow_ms")) {
 		ActionManager::map_some_state ("options",  "DefaultNarrowMS", &Configuration::get_default_narrow_ms);
+	} else if (PARAM_IS ("name-new-markers")) {
+		ActionManager::map_some_state ("options",  "NameNewMarkers", &Configuration::get_name_new_markers);	
 	} else if (PARAM_IS ("rubberbanding-snaps-to-grid")) {
 		ActionManager::map_some_state ("options", "RubberbandingSnapsToGrid", &Configuration::get_rubberbanding_snaps_to_grid);
 	}

colinf

2010-03-19 08:53

updater   ~0007412

I've still got this patch in my working copy, so I guess it never got applied. Is it still an issue?

paul

2010-03-25 15:32

administrator   ~0007420

committed to the 2.X repo. thanks again colin. sorry for the delay on this one.

system

2020-04-19 20:13

developer   ~0021779

Issue has been closed automatically, by Trigger Close Plugin.
Feel free to re-open with additional information if you think the issue is not resolved.

Issue History

Date Modified Username Field Change
2008-07-31 12:43 bennyp New Issue
2008-07-31 18:09 colinf Note Added: 0005125
2008-07-31 18:09 colinf File Added: name-new-markers-state.patch
2010-03-19 08:53 colinf Note Added: 0007412
2010-03-25 15:32 paul cost => 0.00
2010-03-25 15:32 paul Note Added: 0007420
2010-03-25 15:32 paul Status new => resolved
2010-03-25 15:32 paul Resolution open => fixed
2010-03-25 15:32 paul Assigned To => paul
2010-04-24 10:28 cth103 Category bugs => bugs2
2010-04-24 10:29 cth103 Category bugs2 => bugs
2020-04-19 20:13 system Note Added: 0021779
2020-04-19 20:13 system Status resolved => closed