View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0002030 | ardour | bugs | public | 2008-01-17 01:26 | 2008-03-21 14:54 |
Reporter | nowhiskey | Assigned To | paul | ||
Priority | normal | Severity | minor | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Product Version | SVN/2.0-ongoing | ||||
Summary | 0002030: 'unknown import mode string als neue spuren' | ||||
Description | if i start 2.2 as well as ongoing@2927 without the 'LANG=en_US.UTF-8' prefix, ardour will run with german language, but if now i try to import some audio via alt+i, a log window opens with the content: [warning]: programing error: unknown import mode string als neue spuren if i change the import settings to 'to region list' than the end of the log message will catch this setting. how ever, i am not able to close the log window, but if i press 'ok' the import will happen successfully and i can close the log window after it. cheers, doc | ||||
Tags | No tags attached. | ||||
|
I have similar log-messages like: [WARNING]: programming error: unknown import mode string zur Liste der Regionen |
|
A patch for ardour-svn-ongoing (sfdb_ui.cc) is attached. |
2008-03-19 14:29
|
sfdb_ui.patch (2,086 bytes)
Index: gtk2_ardour/sfdb_ui.cc =================================================================== --- gtk2_ardour/sfdb_ui.cc (Revision 3155) +++ gtk2_ardour/sfdb_ui.cc (Arbeitskopie) @@ -65,24 +65,28 @@ ustring SoundFileBrowser::persistent_folder; + static ImportMode -string2importmode (string str) +index2importmode (int index) { - if (str == "as new tracks") { - return ImportAsTrack; - } else if (str == "to selected tracks") { - return ImportToTrack; - } else if (str == "to region list") { - return ImportAsRegion; - } else if (str == "as new tape tracks") { - return ImportAsTapeTrack; + switch(index) { + case 1: + return ImportAsTrack; + break; + case 2: + return ImportAsRegion; + break; + case 3: + return ImportAsTapeTrack; + break; + case 4: + return ImportToTrack; + break; } - - warning << string_compose (_("programming error: unknown import mode string %1"), str) << endmsg; - - return ImportAsTrack; + return ImportAsTrack; } + static string importmode2string (ImportMode mode) { @@ -96,6 +100,7 @@ case ImportAsTapeTrack: return _("as new tape tracks"); } + /*NOTREACHED*/ return _("as new tracks"); } @@ -699,6 +704,12 @@ ustring existing_choice; vector<string> action_strings; + + action_strings.push_back (importmode2string (ImportAsTrack)); + action_strings.push_back (importmode2string (ImportAsRegion)); + action_strings.push_back (importmode2string (ImportAsTapeTrack)); + + if (selected_track_cnt > 0) { if (channel_combo.get_active_text().length()) { ImportDisposition id = get_channel_disposition(); @@ -724,9 +735,6 @@ } } - action_strings.push_back (importmode2string (ImportAsTrack)); - action_strings.push_back (importmode2string (ImportAsRegion)); - action_strings.push_back (importmode2string (ImportAsTapeTrack)); resetting_ourselves = true; @@ -1104,7 +1112,7 @@ ImportMode SoundFileOmega::get_mode () const { - return string2importmode (action_combo.get_active_text()); + return index2importmode (action_combo.get_active()); } void |
|
rev 3163 contains a different, simpler fix for this issue. I'd appreciate if you could check it out and let me know that it works. thanks for the bug report and patch. |
|
Hi Paul, works for me ! Thanks for the fast fix! |
|
see notes. |
|
works again, thanks for fixing!! cheers, doc |
Date Modified | Username | Field | Change |
---|---|---|---|
2008-01-17 01:26 | nowhiskey | New Issue | |
2008-01-17 11:33 | zettberlin | Note Added: 0004662 | |
2008-03-19 14:28 | mauser | Note Added: 0004791 | |
2008-03-19 14:29 | mauser | File Added: sfdb_ui.patch | |
2008-03-21 13:38 | paul | Note Added: 0004796 | |
2008-03-21 13:38 | paul | Status | new => feedback |
2008-03-21 14:03 | mauser | Note Added: 0004797 | |
2008-03-21 14:23 | paul | Status | feedback => resolved |
2008-03-21 14:23 | paul | Resolution | open => fixed |
2008-03-21 14:23 | paul | Assigned To | => paul |
2008-03-21 14:23 | paul | Note Added: 0004798 | |
2008-03-21 14:54 | nowhiskey | Status | resolved => closed |
2008-03-21 14:54 | nowhiskey | Note Added: 0004800 |