View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0001705 | ardour | bugs | public | 2007-05-29 22:03 | 2008-11-21 00:27 |
Reporter | jdavisp3 | Assigned To | paul | ||
Priority | normal | Severity | minor | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Product Version | 2.0 | ||||
Summary | 0001705: cannot 'cancel entire import' | ||||
Description | If you embed a group of files with a sample rate that doesn't match the session rate, you get a dialog per-file where you can: 1. cancel entire import 2. don't embed individual file 3. embed everything without asking But choosing '1', will result in the same behavior as '2', you keep getting dialogs for subsequent files. Also, '1' Should probably say 'cancel entire embed' for consistency. | ||||
Tags | No tags attached. | ||||
2007-06-04 00:51
|
patch (886 bytes)
Index: gtk2_ardour/editor_audio_import.cc =================================================================== --- gtk2_ardour/editor_audio_import.cc (revision 1945) +++ gtk2_ardour/editor_audio_import.cc (working copy) @@ -337,8 +337,8 @@ vector<string> choices; if (multiple_files) { - choices.push_back (_("Cancel entire import")); - choices.push_back (_("Don't embed it")); + choices.push_back (_("Don't embed any")); + choices.push_back (_("Don't embed this one")); choices.push_back (_("Embed all without questions")); Gtkmm2ext::Choice rate_choice ( @@ -350,7 +350,9 @@ switch (resx) { case 0: /* stop a multi-file import */ - case 1: /* don't import this one */ + ret = -2; + goto out; + case 1: /* don't embed this one */ ret = -1; goto out; case 2: /* do it, and the rest without asking */ |
|
The attached patch seems to fix this. It also makes the button text a little more consistent, I think. |
|
hi, i tried applying the patch to 2.0-ongoing and it works very good here! cheers, doc |
2007-07-04 17:22
|
patch2 (509 bytes)
Index: gtk2_ardour/editor_audio_import.cc =================================================================== --- gtk2_ardour/editor_audio_import.cc (revision 2103) +++ gtk2_ardour/editor_audio_import.cc (working copy) @@ -352,7 +352,9 @@ switch (resx) { case 0: /* stop a multi-file import */ - case 1: /* don't import this one */ + ret = -2; + goto out; + case 1: /* don't embed this one */ ret = -1; goto out; case 2: /* do it, and the rest without asking */ |
|
There's a second patch without the text changes. |
|
applied to my code in 2.0-ongoing and will be committed to svn (trunk too) soon |
Date Modified | Username | Field | Change |
---|---|---|---|
2007-05-29 22:03 | jdavisp3 | New Issue | |
2007-06-04 00:51 | jdavisp3 | File Added: patch | |
2007-06-04 00:51 | jdavisp3 | Note Added: 0004059 | |
2007-06-04 08:59 | nowhiskey | Note Added: 0004060 | |
2007-07-04 17:22 | jdavisp3 | File Added: patch2 | |
2007-07-04 17:22 | jdavisp3 | Note Added: 0004097 | |
2007-07-04 19:13 | paul | Status | new => resolved |
2007-07-04 19:13 | paul | Resolution | open => fixed |
2007-07-04 19:13 | paul | Assigned To | => paul |
2007-07-04 19:13 | paul | Note Added: 0004101 | |
2007-07-20 16:10 | paul | Relationship added | has duplicate 0001707 |
2007-07-20 16:13 | paul | Relationship deleted | has duplicate 0001707 |
2008-11-21 00:27 | seablade | Status | resolved => closed |