View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0001636 | ardour | bugs | public | 2007-04-28 12:13 | 2020-04-19 20:12 |
| Reporter | lincoln | Assigned To | cth103 | ||
| Priority | normal | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Summary | 0001636: Wrong group selection with snap set to bar | ||||
| Description | When snap is set to Bar, if you have 2 adjacent regions (say following a split) and you group select the left had region, the right hand region is selected too. Here is a sequence: 1. create a region 4 bars long 2. split at the start of the 2nd bar 3. group select bar 1 with the mouse (by creating a selection box) both regions will be selected. if the first region is 2 bars long and you select the regions with the mouse with a 2 bar selection box, both left and right hand side regions are selected. This is with Adour2 rc2 rev 1745 | ||||
| Tags | No tags attached. | ||||
|
2007-06-09 11:31
|
editor_mouse_cc.patch (1,148 bytes)
Index: gtk2_ardour/editor_mouse.cc
===================================================================
--- gtk2_ardour/editor_mouse.cc (revision 1982)
+++ gtk2_ardour/editor_mouse.cc (working copy)
@@ -4671,9 +4671,11 @@
}
if (!Keyboard::modifier_state_contains (event->button.state, Keyboard::snap_modifier())) {
+
if (drag_info.first_move) {
snap_to (drag_info.grab_frame);
}
+
snap_to (drag_info.current_pointer_frame);
}
@@ -4740,8 +4742,10 @@
begin_reversible_command (_("rubberband selection"));
if (drag_info.grab_frame < drag_info.last_pointer_frame) {
+ drag_info.last_pointer_frame = drag_info.last_pointer_frame - (nframes64_t) 1; //subtract 1 frame so that we do not select the next region when in snap mode
commit = select_all_within (drag_info.grab_frame, drag_info.last_pointer_frame, y1, y2, track_views, op);
} else {
+ drag_info.grab_frame = drag_info.grab_frame - (nframes64_t) 1; //subtract 1 frame so that we do not select the next region when in snap mode
commit = select_all_within (drag_info.last_pointer_frame, drag_info.grab_frame, y1, y2, track_views, op);
}
|
|
|
I have attched a small patch that takes care of this issue. There seems to be an off by one error that is caused by the snap logic. This patch compensates for this so that the next region does not become selectable. Lincoln |
|
|
Patch applied to 3.0 SVN. Thanks! |
|
|
Issue has been closed automatically, by Trigger Close Plugin. Feel free to re-open with additional information if you think the issue is not resolved. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2007-04-28 12:13 | lincoln | New Issue | |
| 2007-06-09 11:31 | lincoln | File Added: editor_mouse_cc.patch | |
| 2007-06-09 11:34 | lincoln | Note Added: 0004064 | |
| 2009-08-24 23:52 | cth103 | cost | => 0.00 |
| 2009-08-24 23:52 | cth103 | Note Added: 0006602 | |
| 2009-08-24 23:52 | cth103 | Status | new => resolved |
| 2009-08-24 23:52 | cth103 | Resolution | open => fixed |
| 2009-08-24 23:52 | cth103 | Assigned To | => cth103 |
| 2020-04-19 20:12 | system | Note Added: 0021515 | |
| 2020-04-19 20:12 | system | Status | resolved => closed |
