View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0001592 | ardour | bugs | public | 2007-04-03 08:48 | 2008-11-21 00:02 |
| Reporter | esaracco | Assigned To | paul | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Summary | 0001592: Sample rate export problem with some translations | ||||
| Description | "N_()" is used instead of "_()", and with some translations it do not work at all. It is a problem because french users (like me :-) ) can not resample exported regions. They even can not choose the conversion quality. The attached patch fix the problem. Bye | ||||
| Tags | No tags attached. | ||||
|
2007-04-03 08:48
|
export_dialog.cc.patch (2,412 bytes)
--- export_dialog-orig.cc 2007-04-03 10:43:03.000000000 +0200
+++ export_dialog.cc 2007-04-03 10:43:18.000000000 +0200
@@ -398,25 +398,25 @@
switch (session->frame_rate()) {
case 22050:
- sample_rate_combo.set_active_text (N_("22.05kHz"));
+ sample_rate_combo.set_active_text (_("22.05kHz"));
break;
case 44100:
- sample_rate_combo.set_active_text (N_("44.1kHz"));
+ sample_rate_combo.set_active_text (_("44.1kHz"));
break;
case 48000:
- sample_rate_combo.set_active_text (N_("48kHz"));
+ sample_rate_combo.set_active_text (_("48kHz"));
break;
case 88200:
- sample_rate_combo.set_active_text (N_("88.2kHz"));
+ sample_rate_combo.set_active_text (_("88.2kHz"));
break;
case 96000:
- sample_rate_combo.set_active_text (N_("96kHz"));
+ sample_rate_combo.set_active_text (_("96kHz"));
break;
case 192000:
- sample_rate_combo.set_active_text (N_("192kHz"));
+ sample_rate_combo.set_active_text (_("192kHz"));
break;
default:
- sample_rate_combo.set_active_text (N_("44.1kHz"));
+ sample_rate_combo.set_active_text (_("44.1kHz"));
break;
}
@@ -1028,15 +1028,15 @@
if (sr_str == N_("22.05kHz")) {
rate = 22050;
- } else if (sr_str == N_("44.1kHz")) {
+ } else if (sr_str == _("44.1kHz")) {
rate = 44100;
- } else if (sr_str == N_("48kHz")) {
+ } else if (sr_str == _("48kHz")) {
rate = 48000;
- } else if (sr_str == N_("88.2kHz")) {
+ } else if (sr_str == _("88.2kHz")) {
rate = 88200;
- } else if (sr_str == N_("96kHz")) {
+ } else if (sr_str == _("96kHz")) {
rate = 96000;
- } else if (sr_str == N_("192kHz")) {
+ } else if (sr_str == _("192kHz")) {
rate = 192000;
} else {
rate = session->frame_rate();
@@ -1196,15 +1196,15 @@
string sr_str = sample_rate_combo.get_active_text();
if (sr_str == N_("22.05kHz")) {
spec.sample_rate = 22050;
- } else if (sr_str == N_("44.1kHz")) {
+ } else if (sr_str == _("44.1kHz")) {
spec.sample_rate = 44100;
- } else if (sr_str == N_("48kHz")) {
+ } else if (sr_str == _("48kHz")) {
spec.sample_rate = 48000;
- } else if (sr_str == N_("88.2kHz")) {
+ } else if (sr_str == _("88.2kHz")) {
spec.sample_rate = 88200;
- } else if (sr_str == N_("96kHz")) {
+ } else if (sr_str == _("96kHz")) {
spec.sample_rate = 96000;
- } else if (sr_str == N_("192kHz")) {
+ } else if (sr_str == _("192kHz")) {
spec.sample_rate = 192000;
} else {
spec.sample_rate = session->frame_rate();
|
|
|
i am not sure that i understand this bug. the idea is that those strings should not be translated at all. what is happening? |
|
|
I've noticed that when those strings are translated, the samplerate is not set at all. It works only when the translated string is the same as the original msgid. But these strings should be localized since their appearance is not the same in all languages. For example in french, "44.1kHz" becomes "44,1 kHz" |
|
|
patch applied and committed. thanks to ccomb for the clarification of the issue. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2007-04-03 08:48 | esaracco | New Issue | |
| 2007-04-03 08:48 | esaracco | File Added: export_dialog.cc.patch | |
| 2007-04-12 15:55 | paul | Note Added: 0003800 | |
| 2007-04-12 16:23 | ccomb | Note Added: 0003801 | |
| 2007-04-12 16:24 | ccomb | Note Edited: 0003801 | |
| 2007-04-12 21:39 | paul | Status | new => resolved |
| 2007-04-12 21:39 | paul | Resolution | open => fixed |
| 2007-04-12 21:39 | paul | Assigned To | => paul |
| 2007-04-12 21:39 | paul | Note Added: 0003803 | |
| 2008-11-21 00:02 | seablade | Status | resolved => closed |
