View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0000988 | ardour | bugs | public | 2005-05-12 17:20 | 2006-03-25 12:17 |
| Reporter | tito | Assigned To | taybin | ||
| Priority | normal | Severity | block | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Summary | 0000988: XML problem: Plugins with leading digit in its name && visible automation borks parsing | ||||
| Description | 1. Add plugin with a leading digit in the name 2. Track automation -> plugins -> choose arbitrary parameter 3. save 4. close 5. Try to reopen: Ardour says error: xmlParseStartTag: invalid element name <10_band_eq-1 track_height="normal"/> ^ | ||||
| Tags | No tags attached. | ||||
|
|
Oh forgot: This happens in <Route> <extra> <GUI> |
|
|
I think I have a fix for this. Coming up after some testing. |
|
2005-05-16 21:09
|
redirect_xml.diff (874 bytes)
Index: audio_time_axis.cc =================================================================== RCS file: /home/las/cvsroot/ardour/ardour/gtk_ardour/audio_time_axis.cc,v retrieving revision 1.96 diff -u -r1.96 audio_time_axis.cc --- audio_time_axis.cc 5 May 2005 19:38:53 -0000 1.96 +++ audio_time_axis.cc 16 May 2005 20:57:31 -0000 @@ -1417,7 +1417,7 @@ /* create a string that is a legal XML node name that can be used to refer to this redirect+port combination */ char state_name[256]; - snprintf (state_name, sizeof (state_name), "%s-%" PRIu32, legalize_for_xml_node (redirect->name()).c_str(), what); + snprintf (state_name, sizeof (state_name), "Redirect-%s-%" PRIu32, legalize_for_xml_node (redirect->name()).c_str(), what); ran->view = new RedirectAutomationTimeAxisView (_session, _route, editor, *this, parent_canvas, name, what, *redirect, state_name); |
|
|
Please try the attached patch. It won't fix old sessions, but will ensure new sessions don't have that problem. |
|
|
Taybin, it's fixed alright. XML node name of plugin's visible automation (state) is now preceded with "Redirect-" and that makes the node name legal. Legalize it ~:) |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2005-05-12 17:20 | tito | New Issue | |
| 2005-05-12 17:20 | tito | => tito@rumford.de | |
| 2005-05-12 17:20 | tito | Name | => Wolfgang Woehl |
| 2005-05-12 17:30 | tito | Note Added: 0002234 | |
| 2005-05-16 18:44 | taybin | Note Added: 0002240 | |
| 2005-05-16 21:09 | taybin | File Added: redirect_xml.diff | |
| 2005-05-16 21:09 | taybin | Note Added: 0002241 | |
| 2005-05-16 23:14 | tito | Note Added: 0002242 | |
| 2005-05-17 02:02 | taybin | Status | new => resolved |
| 2005-05-17 02:02 | taybin | Resolution | open => fixed |
| 2005-05-17 02:02 | taybin | Assigned To | => taybin |
| 2006-03-25 12:17 | tito | Status | resolved => closed |
