View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0009845 | ardour | other | public | 2024-11-05 08:38 | 2024-11-06 15:01 |
| Reporter | fordfrog | Assigned To | |||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | new | Resolution | open | ||
| Platform | amd64 | OS | gentoo linux | OS Version | (any) |
| Product Version | 8.10 | ||||
| Summary | 0009845: implicit function declaration + some severe warnings | ||||
| Description | when building on gentoo, we get some qa warnings: * QA Notice: Found the following implicit function declarations in configure logs: * /var/tmp/portage/media-sound/ardour-8.10-r2/work/Ardour-8.10.0/build/config.log:2425 - syscall * Check that no features were accidentally disabled. * See https://wiki.gentoo.org/wiki/Modern_C_porting. * QA Notice: Package triggers severe warnings which indicate that it * may exhibit random runtime failures. * ../libs/ardour/return.cc:49:81: warning: base class 'ARDOUR::IOProcessor' is uninitialized when used here to access 'ARDOUR::IOProcessor::_bitslot' [-Wuninitialized] * ../libs/ardour/port_insert.cc:50:59: warning: base class 'ARDOUR::IOProcessor' is uninitialized when used here to access 'ARDOUR::IOProcessor::_bitslot' [-Wuninitialized] * ../libs/ctrl-interface/midi_surface/midi_byte_array.cc:47:22: warning: passing an object that undergoes default argument promotion to 'va_start' has undefined behavior [-Wvarargs] * ../libs/surfaces/mackie/midi_byte_array.cc:46:22: warning: passing an object that undergoes default argument promotion to 'va_start' has undefined behavior [-Wvarargs] * ../libs/surfaces/us2400/midi_byte_array.cc:45:22: warning: passing an object that undergoes default argument promotion to 'va_start' has undefined behavior [-Wvarargs] * ../libs/surfaces/launch_control_xl/midi_byte_array.cc:45:22: warning: passing an object that undergoes default argument promotion to 'va_start' has undefined behavior [-Wvarargs] * ../libs/surfaces/push2/midi_byte_array.cc:43:22: warning: passing an object that undergoes default argument promotion to 'va_start' has undefined behavior [-Wvarargs] * ../gtk2_ardour/transcode_ffmpeg.cc:196:69: warning: 'sscanf' may overflow; destination buffer in argument 6 has size 32, but the corresponding specifier may require size 33 [-Wfortify-source] * Please do not file a Gentoo bug and instead report the above QA * issues directly to the upstream developers of this software. this is the error from config.log: [1/1] Compiling build/.conf_check_c12644d0cba308799be2157cb7c1feb3/test.c ['clang', '-I/var/tmp/portage/media-sound/ardour-8.10-r2/work/Ardour-8.10.0', '-march=alderlake', '-mpopcnt', '-mlzcnt', '-mno-cldemote', '-mno-kl', '-mno-pconfig', '-mno-sgx', '-mno-widekl', '-mshstk', '-O2', '-pipe', '-frecord-gcc-switches', '-ggdb3', '-Og', '-lboost_system', '-DHAVE_RF64_RIFF', '-DCOMPILER_INT128_SUPPORT', '-DWAF_BUILD', '-DNDEBUG', '-fshow> err: clang: warning: -lboost_system: 'linker' input unused [-Wunused-command-line-argument] ../test.c:2:10: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes] 2 | int main () { syscall(SYS_ioprio_set, 1, 0, 8192); return 0; } | ^ | void ../test.c:2:15: error: call to undeclared function 'syscall'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] 2 | int main () { syscall(SYS_ioprio_set, 1, 0, 8192); return 0; } | ^ 1 warning and 1 error generated. | ||||
| Tags | No tags attached. | ||||
|
|
The _bitslot warnings are false positives. The compiler you use is not smart enough. I've fixed the -Wfortify-source issue and C99 issue in current git (02fde5f1aa39, ba4d9709c6e44). Thanks for the heads up. |
|
|
thanks for the fixes. i backported them to 8.10 in gentoo. with gcc-14.2.1_p20241026 i get no warnings reported (well, i get two, but those come from the gcc package itself) clang-18.1.8 currently reports these: * QA Notice: Package triggers severe warnings which indicate that it * may exhibit random runtime failures. * ../libs/ardour/port_insert.cc:50:59: warning: base class 'ARDOUR::IOProcessor' is uninitialized when used here to access 'ARDOUR::IOProcessor::_bitslot' [-Wuninitialized] * ../libs/ardour/return.cc:49:81: warning: base class 'ARDOUR::IOProcessor' is uninitialized when used here to access 'ARDOUR::IOProcessor::_bitslot' [-Wuninitialized] * ../libs/ctrl-interface/midi_surface/midi_byte_array.cc:47:22: warning: passing an object that undergoes default argument promotion to 'va_start' has undefined behavior [-Wvarargs] * ../libs/surfaces/mackie/midi_byte_array.cc:46:22: warning: passing an object that undergoes default argument promotion to 'va_start' has undefined behavior [-Wvarargs] * ../libs/surfaces/us2400/midi_byte_array.cc:45:22: warning: passing an object that undergoes default argument promotion to 'va_start' has undefined behavior [-Wvarargs] * ../libs/surfaces/launch_control_xl/midi_byte_array.cc:45:22: warning: passing an object that undergoes default argument promotion to 'va_start' has undefined behavior [-Wvarargs] * ../libs/surfaces/push2/midi_byte_array.cc:43:22: warning: passing an object that undergoes default argument promotion to 'va_start' has undefined behavior [-Wvarargs] so with _bitslot there might be an issue in clang in fact. |
|
|
The syscall issue was initially reported on its own in bug 0009831 -- thanks for the fix. |
