View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0009354 | ardour | bugs | public | 2023-05-27 21:25 | 2023-06-12 19:52 |
| Reporter | colinf | Assigned To | |||
| Priority | normal | Severity | minor | Reproducibility | N/A |
| Status | new | Resolution | open | ||
| Summary | 0009354: No way to remove a single cue marker from a region source | ||||
| Description | There's no way (at least, as far as I can see) to remove a single cue marker from a region's source. There's "Region > Markers > Clear Region Cue Markers" to delete them all, but removing just one seems impossible. | ||||
| Tags | No tags attached. | ||||
|
|
So it appears that ardour's standard <shift>+<right-click> to delete is somehow supposed to be implemented for region cue markers, but in fact provokes an assert() failure in debug builds, thus: An UNDO transaction was started while a prior command was underway. Aborting command (remove cue marker) and prior (remove region marker) ardour-7.3.280: ../libs/ardour/session_state.cc:3327: void ARDOUR::Session::begin_reversible_command(GQuark): Assertion `false' failed. |
|
|
The attached at least gets shift+right-click working to remove a single region cue marker. It still doesn't work quite as well as I'd like: it only removes cue markers if their containing region is selected in 'G'rab mode. I feel it ought to work regardless of whether the region is selected, and ideally in 'D'raw & internal 'E'dit modes too - I'll see whether I can find the time to implement that soon. Otherwise I'll just merge this anyway. 0001-fix-shift-right-click-removal-of-region-source-marke.patch (925 bytes)
From 05849ee45c903e381c8404fe93953d93de448089 Mon Sep 17 00:00:00 2001
From: Colin Fletcher <colin.m.fletcher@googlemail.com>
Date: Mon, 12 Jun 2023 16:43:21 +0100
Subject: [PATCH] fix shift+right-click removal of region source marker
---
gtk2_ardour/editor_markers.cc | 2 --
1 file changed, 2 deletions(-)
diff --git a/gtk2_ardour/editor_markers.cc b/gtk2_ardour/editor_markers.cc
index 9bb7360880..e32d61f557 100644
--- a/gtk2_ardour/editor_markers.cc
+++ b/gtk2_ardour/editor_markers.cc
@@ -889,7 +889,6 @@ Editor::really_remove_global_marker (Location* loc)
gint
Editor::really_remove_region_marker (ArdourMarker* marker)
{
- begin_reversible_command (_("remove region marker"));
RegionView* rv = marker->region_view();
if (!rv) {
@@ -905,7 +904,6 @@ Editor::really_remove_region_marker (ArdourMarker* marker)
remove_region_marker (cm);
- commit_reversible_command ();
return FALSE;
}
--
2.30.2
|
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2023-05-27 21:25 | colinf | New Issue | |
| 2023-06-03 16:50 | colinf | Note Added: 0027701 | |
| 2023-06-03 18:06 | colinf | Category | features => bugs |
| 2023-06-12 19:52 | colinf | Note Added: 0027743 | |
| 2023-06-12 19:52 | colinf | File Added: 0001-fix-shift-right-click-removal-of-region-source-marke.patch |
