View Issue Details

IDProjectCategoryView StatusLast Update
0000926ardourbugspublic2008-11-20 23:42
Reporterrtfm Assigned Topaul  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Summary0000926: crossfade shape not saved
DescriptionWhen setting crossfade "shape", the characteristics of the crossfade are not saved in either the snapshot or regular saves. It reverts to the default shape upon load.
Additional InformationThis problem was reproducible with version 0.9beta28
TagsNo tags attached.

Activities

2005-05-08 20:23

 

crossfade.patch (503 bytes)   
*** libs/ardour/crossfade.cc.ori	2005-02-18 13:31:25.000000000 +0100
--- libs/ardour/crossfade.cc	2005-05-08 21:37:34.425529440 +0200
***************
*** 151,161 ****
  		throw failed_constructor();
  	}
  
  	if (set_state (node)) {
  		throw failed_constructor();
  	}
- 
- 	initialize ();
  }
  
  Crossfade::~Crossfade ()
--- 151,161 ----
  		throw failed_constructor();
  	}
  
+ 	initialize ();
+ 	
  	if (set_state (node)) {
  		throw failed_constructor();
  	}
  }
  
  Crossfade::~Crossfade ()
crossfade.patch (503 bytes)   

mschwarzenberg

2005-05-08 20:25

reporter   ~0002221

Last edited: 2005-05-10 07:32

The bug is still present in Ardour/GTK 0.9beta29
   (built using 0.594.4 with libardour 0.891.1)

I'm not shure what is meant by 'setting crossfade "shape"', but the bug clearly exists for "full crossfades" whith edited fade-in/fade-out envelopes.

The tiny patch (crossfade.patch) attached seems to fix the problem. Actually, the crosfade shape IS saved (have look at the *.ardour file) but the values to be restored were overwritten by Crossfade::initialize().

Markus Schwarzenberg

paul

2005-05-10 10:52

administrator   ~0002223

patch applied to paul's code. thanks.

Issue History

Date Modified Username Field Change
2005-03-12 05:13 rtfm New Issue
2005-03-12 05:13 rtfm E-mail => jeff@ourexchange.net
2005-05-08 20:23 mschwarzenberg File Added: crossfade.patch
2005-05-08 20:25 mschwarzenberg Note Added: 0002221
2005-05-10 07:32 mschwarzenberg Note Edited: 0002221
2005-05-10 10:52 paul Status new => resolved
2005-05-10 10:52 paul Resolution open => fixed
2005-05-10 10:52 paul Assigned To => paul
2005-05-10 10:52 paul Note Added: 0002223
2008-11-20 23:42 seablade Status resolved => closed