View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0008999 | ardour | bugs | public | 2022-10-17 13:33 | 2022-10-17 17:17 |
| Reporter | umlaeute | Assigned To | |||
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | new | Resolution | open | ||
| Platform | Debian GNU | OS | Linux | OS Version | (any) |
| Product Version | 7.0 | ||||
| Summary | 0008999: bashism in launch script | ||||
| Description | the script generated by 'gtk2_ardour/ardour.sh.in' contains a call to 'ulimit' which is a bash-builtin (and not mandated by POSIX sh). however, the generated scripts uses '#!/bin/sh' as a shebang, indicating that this is a POSIX-compliant script. | ||||
| Steps To Reproduce | ```sh $ checkbashisms gtk2_ardour/ardour.sh.in possible bashism in gtk2_ardour/ardour.sh.in line 14 (ulimit): MLOCK_LIMIT=$(ulimit -l) $ shellcheck gtk2_ardour/ardour.sh.in In gtk2_ardour/ardour.sh.in line 14: MLOCK_LIMIT=$(ulimit -l) ^-- SC3045 (warning): In POSIX sh, ulimit -l is undefined. ``` | ||||
| Tags | No tags attached. | ||||
|
|
Can we rely on bash being present? dash can also handle it just fine. I think it is fine if the check fails when `ulimit` is not available. perhaps the proper solution is to add a 2>/dev/null or fall back to prlimit if that is available |
|
|
ulimit is a part of POSIX 1-2017 Section 12.2, Utility Syntax Guidelines. What you actually mean is that the -l argument to ulimit is not defined by POSIX |
|
|
yes. |
|
|
"yes" as in: "the -l argument to ulimit is not defined by POSIX". (rather than: "yes, just ignore 'ulimit' not working") |
