View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0007668 | ardour | bugs | public | 2018-09-29 17:01 | 2020-04-19 20:18 |
| Reporter | johne53 | Assigned To | johne53 | ||
| Priority | urgent | Severity | crash | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| OS | Windows | ||||
| Product Version | 5.X git (version in description) | ||||
| Summary | 0007668: VST plugins crashing due to 'idle' implementation | ||||
| Description | Back on 30th July, commit #98769796d7 modified 'libs/ardour/session_vst.cc' to remove an 'idle()' implementation when responding to the VST message 'audioMasterUpdateDisplay'. This was done in response to a bug reported on the Mixbus forum which was causing a particular plugin to crash:- http://mixbus.harrisonconsoles.com/forum/thread-6229-post-37127.html I've just noticed that commit #9ccace8f0d effectively re-implemented the idle functionality (albeit using a different strategy). However, this has simply re-introduce the bug - which now affects other plugins apart from the original one:- http://mixbus.harrisonconsoles.com/forum/thread-6497.html | ||||
| Steps To Reproduce | See Tassy's Youtube video here:- https://www.youtube.com/watch?v=yYUSNlez5RU&feature=youtu.be | ||||
| Additional Information | Reverting commit #9ccace8f0d removes the crashes | ||||
| Tags | No tags attached. | ||||
| related to | 0007766 | new | Ardour crashses |
|
|
If you revert 9ccace8f0d then you can also remove the function fst_audio_master_idle() form the codebase. But I think the issue is rather in void fst_audio_master_idle(void) { while(g_main_context_iteration(NULL, FALSE)); } that may live-loops if a system is overloaded and never idles. Or there may be a deeper event-loop issue here. PS. 98769796d7c is unrelated here, that called the plugin's effEditIdle. |
|
|
Thanks Robin, It looks like fst_audio_master_idle() got added a few years ago to solve a different issue with VST plugins but I've a feeling it shouldn't get used as a response to this particular event. In this case I'd be tempted to take it out as it mostly seems to cause problems. |
|
|
This seems fixed now if somebody wants to mark it as resolved [Edit...] oops - I just realised I can do it myself !! |
|
|
Issue has been closed automatically, by Trigger Close Plugin. Feel free to re-open with additional information if you think the issue is not resolved. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2018-09-29 17:01 | johne53 | New Issue | |
| 2018-09-30 19:34 | x42 | Note Added: 0020393 | |
| 2018-10-01 11:00 | johne53 | Note Added: 0020394 | |
| 2018-10-12 17:05 | johne53 | Note Added: 0020398 | |
| 2018-10-12 17:06 | johne53 | Note Edited: 0020398 | |
| 2018-10-12 17:06 | johne53 | Status | new => resolved |
| 2018-10-12 17:06 | johne53 | Resolution | open => fixed |
| 2018-10-12 17:06 | johne53 | Assigned To | => johne53 |
| 2018-10-12 17:07 | johne53 | Note Edited: 0020398 | |
| 2019-06-12 22:43 | x42 | Relationship added | related to 0007766 |
| 2020-04-19 20:18 | system | Note Added: 0023785 | |
| 2020-04-19 20:18 | system | Status | resolved => closed |
