View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0007141 | ardour | bugs | public | 2016-11-25 17:40 | 2020-04-19 20:18 |
| Reporter | robsco | Assigned To | timbyr | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | 5.X git (version in description) | ||||
| Fixed in Version | 5.X git (version in description) | ||||
| Summary | 0007141: 2 playlists are created on the new track when duplicating a track that has only 1 playlist using "Create new (empty) playlists" | ||||
| Description | The attached video should display the issue if the summary does not make sense. Ardour 5.4.99 "In a Land of Clear Colours" (rev 5.4-455-g43b468a) Intel 64-bit | ||||
| Tags | No tags attached. | ||||
|
|
|
|
|
I can confirm this issue with nightly build version 5.4.456 |
|
|
The patch attached fix the problem. When duplicating a track, a new route is build in Session::new_route_from_template by XMLRouteFactory. XMLRouteFactory creates for us a new Playlist. The call to track->use_new_playlist(), creates again a new playlist.That's why there were 2 playlists in the duplicated track. Removing the call to use_new_playlist() fix the issue. |
|
|
fix-7141.patch (464 bytes)
diff --git a/libs/ardour/session.cc b/libs/ardour/session.cc
index 7239607..1273674 100644
--- a/libs/ardour/session.cc
+++ b/libs/ardour/session.cc
@@ -3333,7 +3333,6 @@ Session::new_route_from_template (uint32_t how_many, PresentationInfo::order_t i
if ((track = boost::dynamic_pointer_cast<Track> (route))) {
switch (pd) {
case NewPlaylist:
- track->use_new_playlist ();
break;
case CopyPlaylist:
track->use_copy_playlist ();
|
|
|
Thanks for the patch. It fixes the duplicate "Create new (empty) playlists" issue. There is still an issue duplicate "Copy playlists". It does not copy the regions to the new track's playlist and also, two playlists empty playlists are created on the new track. |
|
|
I committed the patch on master as f50ab8cc and will be in a nightly build >= 5.4.467 Thanks again for the patch I also noticed the issue with duplicate track and Copy playlists. |
|
|
I've committed a fix for the issue with Duplicate Track with a Copied Playlist as e9eea8de and it will be in a nighly build >= 5.4.470 Please test and if there are any issues please open a separate bug report, thanks. I'm marking this issue as resolved. |
|
|
Ok, Duplicate Track with a Copied Playlist works as expected. |
|
|
Issue has been closed automatically, by Trigger Close Plugin. Feel free to re-open with additional information if you think the issue is not resolved. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2016-11-25 17:40 | robsco | New Issue | |
| 2016-11-25 17:40 | robsco | File Added: playlists_duplicate_copy.mkv | |
| 2016-11-26 10:06 | timbyr | Note Added: 0019052 | |
| 2016-11-26 10:06 | timbyr | Status | new => confirmed |
| 2016-11-27 20:18 | elgoun | Note Added: 0019066 | |
| 2016-11-27 20:18 | elgoun | File Added: fix-7141.patch | |
| 2016-11-28 00:43 | robsco | Note Added: 0019067 | |
| 2016-11-28 01:16 | timbyr | Note Added: 0019068 | |
| 2016-11-28 02:45 | timbyr | Note Added: 0019072 | |
| 2016-11-28 02:46 | timbyr | Status | confirmed => resolved |
| 2016-11-28 02:46 | timbyr | Fixed in Version | => 5.X git (version in description) |
| 2016-11-28 02:46 | timbyr | Resolution | open => fixed |
| 2016-11-28 02:46 | timbyr | Assigned To | => timbyr |
| 2016-11-28 02:46 | timbyr | Note Edited: 0019072 | |
| 2016-11-28 02:47 | timbyr | Note Edited: 0019072 | |
| 2016-11-28 03:35 | elgoun | Note Added: 0019075 | |
| 2020-04-19 20:18 | system | Note Added: 0023683 | |
| 2020-04-19 20:18 | system | Status | resolved => closed |
