View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0006350 | ardour | bugs | public | 2015-05-27 05:17 | 2020-04-19 20:17 |
| Reporter | ovenwerks | Assigned To | paul | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | 4.X git (version in description) | ||||
| Summary | 0006350: mcp surface control: Bank math error. left at bank 0 then right goes to max bank. | ||||
| Description | integer math with -1 does strange things attached patch catches left at zero case. | ||||
| Tags | No tags attached. | ||||
|
2015-05-27 05:20
|
patch.txt (621 bytes)
diff --git a/libs/surfaces/mackie/mcp_buttons.cc b/libs/surfaces/mackie/mcp_buttons.cc
index ee04d68..1cb388d 100644
--- a/libs/surfaces/mackie/mcp_buttons.cc
+++ b/libs/surfaces/mackie/mcp_buttons.cc
@@ -102,8 +102,12 @@ MackieControlProtocol::left_press (Button &)
DEBUG_TRACE (DEBUG::MackieControl, string_compose ("bank left with current initial = %1 nstrips = %2 tracks/busses = %3\n",
_current_initial_bank, strip_cnt, sorted.size()));
-
+ if (_current_initial_bank > 0) {
switch_banks ((_current_initial_bank - 1) / strip_cnt * strip_cnt);
+ } else {
+ switch_banks (0);
+ }
+
return on;
}
|
|
|
comitted and pushed, thanks. |
|
|
Issue has been closed automatically, by Trigger Close Plugin. Feel free to re-open with additional information if you think the issue is not resolved. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2015-05-27 05:17 | ovenwerks | New Issue | |
| 2015-05-27 05:20 | ovenwerks | File Added: patch.txt | |
| 2015-05-27 13:03 | paul | Note Added: 0016738 | |
| 2015-05-27 13:03 | paul | Status | new => resolved |
| 2015-05-27 13:03 | paul | Resolution | open => fixed |
| 2015-05-27 13:03 | paul | Assigned To | => paul |
| 2020-04-19 20:17 | system | Note Added: 0023471 | |
| 2020-04-19 20:17 | system | Status | resolved => closed |
