View Issue Details

IDProjectCategoryView StatusLast Update
0006305ardourbugspublic2020-04-19 20:17
Reporterovenwerks Assigned Topaul  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version4.X git (version in description) 
Summary0006305: Control Surface: MCP profile editor has a blank line in "transport"
DescriptionWhen using the mcp profile editor to set an action to an mcp button, under transport. Selecting this blank space shows up in the *.profile file as:
<Button name="F1" plain="Transport/ToggleExternalSync"/>

Ardour 4.0.210dbg nightly binary.
Tagscontrol, shortcuts, surface

Activities

ovenwerks

2015-05-27 04:21

reporter   ~0016735

This problem also shows up in the Window -> Key Bindings Dialog. This would suggest both problems are related.

2015-05-28 20:03

 

patch.txt (928 bytes)   
diff --git a/gtk2_ardour/ardour_ui_ed.cc b/gtk2_ardour/ardour_ui_ed.cc
index ca23560..a2209c5 100644
--- a/gtk2_ardour/ardour_ui_ed.cc
+++ b/gtk2_ardour/ardour_ui_ed.cc
@@ -416,7 +416,7 @@ if (Profile->get_mixbus())
 	ActionManager::session_sensitive_actions.push_back (act);
 	act = ActionManager::register_toggle_action (transport_actions, X_("ToggleTimeMaster"), _("Time Master"), sigc::mem_fun(*this, &ARDOUR_UI::toggle_time_master));
 	ActionManager::session_sensitive_actions.push_back (act);
-	act = ActionManager::register_toggle_action (transport_actions, X_("ToggleExternalSync"), "", sigc::mem_fun(*this, &ARDOUR_UI::toggle_external_sync));
+	act = ActionManager::register_toggle_action (transport_actions, X_("ToggleExternalSync"), _("External Positional Sync"), sigc::mem_fun(*this, &ARDOUR_UI::toggle_external_sync));
 	ActionManager::session_sensitive_actions.push_back (act);
 
 	for (int i = 1; i <= 32; ++i) {
patch.txt (928 bytes)   

ovenwerks

2015-05-28 20:05

reporter   ~0016746

The patch in the attached file adds the text "External Positional Sync" to both the key bindings dialog as well as the mackie control surface profile editor action selector.

paul

2015-05-28 20:22

administrator   ~0016747

fixed by related by separate change in 1291f3d2e82. thanks.

system

2020-04-19 20:17

developer   ~0023456

Issue has been closed automatically, by Trigger Close Plugin.
Feel free to re-open with additional information if you think the issue is not resolved.

Issue History

Date Modified Username Field Change
2015-05-05 04:12 ovenwerks New Issue
2015-05-27 04:19 ovenwerks Tag Attached: control
2015-05-27 04:19 ovenwerks Tag Attached: shortcuts
2015-05-27 04:19 ovenwerks Tag Attached: surface
2015-05-27 04:21 ovenwerks Note Added: 0016735
2015-05-28 20:03 ovenwerks File Added: patch.txt
2015-05-28 20:05 ovenwerks Note Added: 0016746
2015-05-28 20:22 paul Note Added: 0016747
2015-05-28 20:22 paul Status new => resolved
2015-05-28 20:22 paul Resolution open => fixed
2015-05-28 20:22 paul Assigned To => paul
2020-04-19 20:17 system Note Added: 0023456
2020-04-19 20:17 system Status resolved => closed