View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0006185 | ardour | bugs | public | 2015-02-27 11:10 | 2015-03-03 12:02 |
| Reporter | tlat | Assigned To | |||
| Priority | normal | Severity | minor | Reproducibility | sometimes |
| Status | new | Resolution | open | ||
| Summary | 0006185: waveform disappears during recording | ||||
| Description | it f4203cc example: - add track - arm track - play and [toggle record] multiple times (not like in olympic video games) sometimes the waveform disappears cause: the rectangle is also hidden when the last recorded data frame coincides with the start of the region. Attached a patch. | ||||
| Tags | No tags attached. | ||||
|
2015-02-27 11:10
|
waveform_disappears.patch (452 bytes)
diff --git a/gtk2_ardour/audio_streamview.cc b/gtk2_ardour/audio_streamview.cc
index 7951848..baec4a9 100644
--- a/gtk2_ardour/audio_streamview.cc
+++ b/gtk2_ardour/audio_streamview.cc
@@ -369,7 +369,7 @@ AudioStreamView::update_rec_regions (framepos_t start, framecnt_t cnt)
rect->set_x1 (xend);
}
- } else {
+ } else if (last_rec_data_frame < region->start()) {
framecnt_t nlen = _trackview.track()->get_captured_frames(n);
|
|
|
Hello, I'm trying to understand the issue but I'm having trouble reproducing it. When I follow your steps to reproduce I am not seeing any instances where a waveform disappears. Are you saying that the waveform appears and then is hidden somehow? I do see the behavior where the waveform does not appear if the recorded region is less than a certain length(until playback is stopped). Is this what you mean? I have tried with your patch and cannot see any difference in behavior but perhaps I'm trying the wrong things. Can you please provide more specific instructions to reproduce your issue. |
|
|
Ok. In the first line of the next example, "T" means "Toggle Record". The second line shows the waveform of the regions during the recording. Arm an audio track and: <code> Play T T T T T T T T Stop .^.^.^.^ ^.^.^. .^. .^.^.^.^. ^^^^^^ hidden </code> I can always reproduce it on linux x86_64 but not with the same intervals or number of toggle-record events. The waveform is hidden because sometimes (at least on my machine) last_rec_data_frame == region->start() and the `else' branch in audio_streamview.cc:372 contains `rect->hide()'. The rectangle is hidden but the recording continues without problems (however see http://tracker.ardour.org/view.php?id=6183) and the complete waveform of the (quasi) hidden chunk appears after "stop": <code> .^.^.^.^ ^.^.^. .^.^.^.^. .^.^.^.^. </code> The patch skips the branch when there aren't recorded data from the last recorded frame to the start of the current temporary region. |
|
|
Attached example.txt for ascii displays |
|
2015-03-03 11:09
|
example.txt (319 bytes)
(T = Toggle Record)
Arm an audio track and:
Play T T T T T T T T Stop
.^.^.^.^ ^.^.^. .^. .^.^.^.^.
^^^^^^
hidden
After stop:
.^.^.^.^ ^.^.^. .^.^.^.^. .^.^.^.^.
|
|
|
Thanks for that explanation. I still can't reproduce this issue, the only time I ever hit that branch where last_rec_data_frame < region->start() is if I enable/disable record extremely fast(button bash) and then the entire GUI is totally unresponsive anyway with no updates. Perhaps another developer that has a better understanding of that section of code will verify whether you patch is correct. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2015-02-27 11:10 | tlat | New Issue | |
| 2015-02-27 11:10 | tlat | File Added: waveform_disappears.patch | |
| 2015-03-03 01:41 | timbyr | Note Added: 0016386 | |
| 2015-03-03 07:59 | tlat | Note Added: 0016387 | |
| 2015-03-03 08:02 | tlat | Note Edited: 0016387 | |
| 2015-03-03 08:06 | tlat | Note Added: 0016388 | |
| 2015-03-03 11:09 | tlat | File Added: example.txt | |
| 2015-03-03 11:10 | tlat | Note Edited: 0016388 | |
| 2015-03-03 12:02 | timbyr | Note Added: 0016389 |
