View Issue Details

IDCategoryLast Update
0006182bugs2017-01-04 05:52
ReportertlatAssigned To 
Reproducibilityalways 
Status confirmedResolutionopen 
Product Version5.3 
Fixed in Version 
Summary0006182: no loop from range markers
Descriptiongit acd6810

example:

- new session
- new track
- record or import something
- select a time range and "Add Range Markers"
- right click on the new mark and "Loop Range"

  result: no loop

It works with the attached patch.

Note: if the original intention is not to bypass the command
history, `marker_menu_loop_range' could use only `set_loop_range'
and `request_play_loop'.
TagsNo tags attached.

Relationships

related to 0007195 closedx42 Seemingly impossible to play loop or set loop range 

Activities

2015-02-25 14:20

 

loop_from_range_markers.patch (527 bytes)
diff --git a/gtk2_ardour/editor_markers.cc b/gtk2_ardour/editor_markers.cc
index d982de3..1a15f9e 100644
--- a/gtk2_ardour/editor_markers.cc
+++ b/gtk2_ardour/editor_markers.cc
@@ -1241,6 +1241,9 @@ Editor::marker_menu_loop_range ()
 			// enable looping, reposition and start rolling
 			_session->request_locate (l2->start(), true);
 			_session->request_play_loop(true);
+		} else {
+			set_loop_range (l->start(), l->end(), _("set loop range from range markers"));
+			_session->request_play_loop (true, true);
 		}
 	}
 }

timbyr

2015-03-09 12:29

developer   ~0016405

I can reproduce the issue here and can confirm that your patch does fix the issue in that it starts looped playback based on the position of the range markers if a loop range doesn't exist.

One issue I noticed with it though is that if you undo setting the loop range from range markers with looping enabled then you can't disable looped playback. I think this issue with undo is a lesser bug that not looping though.

timbyr

2016-09-19 09:00

developer   ~0018686

This is still an issue in 5.3

Issue History

Date Modified Username Field Change
2015-02-25 14:20 tlat New Issue
2015-02-25 14:20 tlat File Added: loop_from_range_markers.patch
2015-03-09 12:29 timbyr Note Added: 0016405
2015-03-09 12:29 timbyr Status new => confirmed
2016-09-19 08:58 timbyr Product Version => 5.3
2016-09-19 09:00 timbyr Note Added: 0018686
2017-01-04 05:52 timbyr Relationship added related to 0007195