View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0006163ardourotherpublic2015-02-08 18:202020-04-19 20:17
Reporterma120mk11 Assigned Totimbyr  
PrioritynormalSeveritytweakReproducibilityalways
Status closedResolutionfixed 
Summary0006163: Tempo lines should be visible inside loop range
DescriptionWhen enabling loop, the tempo lines disappears in the loop range.

It is much easier to edit midi with the tempo lines visible, and I often edit midi when looping...

Ardour Nightly 3.5.4425
Additional InformationIncluded screenshot
first one - loop on
second one loop off
TagsNo tags attached.

Activities

2015-02-08 18:20

 

loop.png (318,839 bytes)

timbyr

2015-02-09 01:29

developer   ~0016337

Confirmed in master@b1dafe

I'm attaching a patch that should address the issue. Not sure if it is the correct approach but it does improve the visibility of the measure lines.

2015-02-09 01:30

 

bug6163.patch (693 bytes)    
diff --git a/gtk2_ardour/dark.colors b/gtk2_ardour/dark.colors
index 39d713c..060f4a1 100644
--- a/gtk2_ardour/dark.colors
+++ b/gtk2_ardour/dark.colors
@@ -487,7 +487,7 @@
     <Modifier name="ghost track base" modifier="= alpha:0.640782"/>
     <Modifier name="ghost track midi fill" modifier="= alpha:0.3"/>
     <Modifier name="inactive crossfade" modifier="= alpha:0.4666"/>
-    <Modifier name="loop rectangle" modifier="= alpha:0.9764"/>
+    <Modifier name="loop rectangle" modifier="= alpha:0.5"/>
     <Modifier name="marker bar" modifier="= alpha:0.5"/>
     <Modifier name="measure line beat" modifier="= alpha:1.0"/>
     <Modifier name="midi frame base" modifier="= alpha:0.4"/>
bug6163.patch (693 bytes)   

timbyr

2015-02-16 02:00

developer   ~0016345

I've committed the attached patch to the master branch. Please confirm that the issue is fixed if you can. Thanks.

ma120mk11

2015-02-18 10:17

reporter   ~0016348

Hi, I tried it with Nightly 3.5.4519 and the issue is still there.

2015-02-18 10:46

 

measure-lines-loop-enabled.png (41,547 bytes)   
measure-lines-loop-enabled.png (41,547 bytes)   

timbyr

2015-02-18 10:50

developer   ~0016349

I've attached an image of what it looks like for me on linux with the Nightly 3.5.4519 build. Is it different for you? Can you see if restoring the theme to the default in preferences helps at all?

ma120mk11

2015-02-18 10:53

reporter   ~0016350

Resoring the theme in preferences did it. Thanks!

timbyr

2015-02-18 11:03

developer   ~0016351

Fixed in 6fd947fe8

system

2020-04-19 20:17

developer   ~0023393

Issue has been closed automatically, by Trigger Close Plugin.
Feel free to re-open with additional information if you think the issue is not resolved.

Issue History

Date Modified Username Field Change
2015-02-08 18:20 ma120mk11 New Issue
2015-02-08 18:20 ma120mk11 File Added: loop.png
2015-02-09 01:29 timbyr Note Added: 0016337
2015-02-09 01:29 timbyr Status new => confirmed
2015-02-09 01:30 timbyr File Added: bug6163.patch
2015-02-16 02:00 timbyr Note Added: 0016345
2015-02-16 02:00 timbyr Status confirmed => feedback
2015-02-18 10:17 ma120mk11 Note Added: 0016348
2015-02-18 10:46 timbyr File Added: measure-lines-loop-enabled.png
2015-02-18 10:50 timbyr Note Added: 0016349
2015-02-18 10:53 ma120mk11 Note Added: 0016350
2015-02-18 11:03 timbyr Note Added: 0016351
2015-02-18 11:03 timbyr Status feedback => resolved
2015-02-18 11:03 timbyr Resolution open => fixed
2015-02-18 11:03 timbyr Assigned To => timbyr
2020-04-19 20:17 system Note Added: 0023393
2020-04-19 20:17 system Status resolved => closed