View Issue Details

IDProjectCategoryView StatusLast Update
0006117ardourbugspublic2020-04-19 20:17
ReporterBenLoftis Assigned Tox42  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Summary0006117: faders do not obey the "highlight" option
DescriptionFaders don't obey the "highlight" option. I believe the root cause (code-wise) is that pixfaders can't see ARDOUR_UI::config.

My preferred fix is to create an ArdourFader widget, which is_a pixfader, but can see the config settings. But perhaps other smarter people have a different/better solution.
TagsNo tags attached.

Activities

x42

2015-01-28 01:05

administrator   ~0016287

A cleaner way (code separation) is to just tell the fader(s) whenever the config changes. That is used throughout the canvas. Eventually all ardour_* cairo-widgets in gtk2_ardour should be moved into a dedicated widget/toolkit folder.

see canvas/wave_view.cc e.g. `global_logscale` for an example.

x42

2015-01-28 01:10

administrator   ~0016288

BTW CairoWidgets in gtk2mmext already have honor flat_buttons see `set_flat_buttons()` very similar concept used throughout all widgets.

-> No special sub-classing of the widget in gtk2ardour is needed. The config is pushed whenever it changes (and not polled by the widget itself every time the widget renders itself).

x42

2015-01-28 01:27

administrator   ~0016289

implemented in 3.5-4392-gde85bfd

system

2020-04-19 20:17

developer   ~0023372

Issue has been closed automatically, by Trigger Close Plugin.
Feel free to re-open with additional information if you think the issue is not resolved.

Issue History

Date Modified Username Field Change
2015-01-08 17:55 BenLoftis New Issue
2015-01-28 01:05 x42 Note Added: 0016287
2015-01-28 01:10 x42 Note Added: 0016288
2015-01-28 01:27 x42 Note Added: 0016289
2015-01-28 01:27 x42 Status new => resolved
2015-01-28 01:27 x42 Resolution open => fixed
2015-01-28 01:27 x42 Assigned To => x42
2020-04-19 20:17 system Note Added: 0023372
2020-04-19 20:17 system Status resolved => closed