View Issue Details

IDProjectCategoryView StatusLast Update
0000595ardourbugspublic2008-11-20 23:39
ReporterJeff Assigned Topaul  
PriorityurgentSeveritycrashReproducibilityalways
Status closedResolutionfixed 
Summary0000595: Removing "master out" will result in crash
Description
To reproduce:

1) Create new session
2) Remove "master out" buss
3) Add a new buss

Ardour crashes.
Additional InformationI'm testing beta 17.1

It appears that Ardour runs with the expectation of always having a valid master out buss (ARDOUR::Session::_master_out)

Look at line 1482 of session.cc (Session::remove_route()). If &route == _master_out you're in trouble since _master_out becomes a dangling pointer after the route is deallocated.

Adding the code after session.cc, line 1483:

if (&route == _master_out)
{
   _master_out = 0;
}

seems to fix the crash, but I'm not sure if that breaks the behavior that was intended.

Are you supposed to be able to delete the master out?








TagsNo tags attached.

Activities

paul

2004-07-09 16:27

administrator   ~0001207

fixed in CVS, along with a related patch for control outs. thanks for your tracking this down.

its not "expected" to remove these busses, buts its UI decision, and so the backend should handle it.

Issue History

Date Modified Username Field Change
2004-07-06 20:51 Jeff New Issue
2004-07-09 16:27 paul Status new => resolved
2004-07-09 16:27 paul Resolution open => fixed
2004-07-09 16:27 paul Assigned To => paul
2004-07-09 16:27 paul Note Added: 0001207
2008-11-20 23:39 seablade Status resolved => closed