View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0005765 | ardour | features | public | 2013-11-10 12:16 | 2020-04-19 20:16 |
| Reporter | colinf | Assigned To | colinf | ||
| Priority | normal | Severity | minor | Reproducibility | N/A |
| Status | closed | Resolution | fixed | ||
| Summary | 0005765: Mouse click outside clock in edit mode should act as if 'enter' pressed | ||||
| Description | If you click in a clock and make changes from the keyboard, it's confusing that those changes disappear and the clock resets to its previous value if you just click outside the clock without pressing a key to confirm the changed value. I know that there are different keys to confirm whether the entered value is relative (+/-) to the previously displayed time, or absolute, but I think it would make sense to assume that the user wants to set the absolute time of the clock if they don't explicitly request otherwise. | ||||
| Tags | No tags attached. | ||||
|
|
The consensus on IRC currently is that: Mouse click outside clock in edit mode should act as if 'ESC' pressed. The two main arguments for this are * make accidental clicks (both to enter clock edit as well as exit clock edit) NOOPs. * If the clock is in text entry mode, entries should be confirmed by keyboard (not mouse). There's no really strong argument either way, though. |
|
|
I'd argue that it should be changed. It's already caused confusion in the 'Insert Time' dialogue (https://community.ardour.org/node/7618, though in that case the confusion was also compounded by some other bugs). As for making accidental clicks NOOPs, even with this change the clock value would remain unchanged if the user didn't type anything to change the value, and if they did type something, I think it's fair to assume that they typed it with the intention of changing the clock rather than having their entry disappear into thin air. Finally, I'd make the argument for consistency with text-editing in other places: e.g. when renaming a track, the newly-typed name is applied as soon as you click outside the name; you have to explicitly press <Esc> to discard the newly-typed name. |
|
|
I just want to bump this issue, because I spent several minutes the other day wondering why the "Insert Time" dialogue wasn't working, until remembering that I have to press <Enter> after inputting the amount of time to insert, before clicking the 'Insert time' button. I fear that if even I puzzled over this after having submitted the bug report, it might be quite likely to trip up other users too. |
|
|
I've fixed this in c41d51e8 for the case of the insert/remove time dialogues. There may be other clocks that could benefit from 'accept changes on focus out', but these were the ones where I found it most confusing. |
|
|
Issue has been closed automatically, by Trigger Close Plugin. Feel free to re-open with additional information if you think the issue is not resolved. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2013-11-10 12:16 | colinf | New Issue | |
| 2013-11-11 01:55 | x42 | Note Added: 0015481 | |
| 2013-11-11 11:36 | colinf | Note Added: 0015482 | |
| 2015-02-11 16:55 | colinf | Note Added: 0016341 | |
| 2015-06-17 17:41 | colinf | Note Added: 0016788 | |
| 2015-06-17 17:41 | colinf | Status | new => resolved |
| 2015-06-17 17:41 | colinf | Resolution | open => fixed |
| 2015-06-17 17:41 | colinf | Assigned To | => colinf |
| 2020-04-19 20:16 | system | Note Added: 0023289 | |
| 2020-04-19 20:16 | system | Status | resolved => closed |
