View Issue Details

IDProjectCategoryView StatusLast Update
0005644ardourotherpublic2013-08-15 16:00
Reportertom_ Assigned To 
PrioritynormalSeveritytextReproducibilityN/A
Status closedResolutionwon't fix 
Product Version3.0 
Summary0005644: Add "..." to Menu Items
Description
added "..." for some menu items that pop up a dialogue:

TagsNo tags attached.

Activities

2013-08-08 18:43

 

menu_labels_points_postfix.patch (5,928 bytes)   
From c2f1b22ebc32888ea5ef88a466bccd3bfc581121 Mon Sep 17 00:00:00 2001
From: Thomas Brand <tom@trellis.ch>
Date: Thu, 8 Aug 2013 20:40:27 +0200
Subject: [PATCH] add ... to menu labels

---
 gtk2_ardour/ardour_ui.cc      |    6 +++---
 gtk2_ardour/ardour_ui_ed.cc   |   10 +++++-----
 gtk2_ardour/editor_actions.cc |    4 ++--
 3 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/gtk2_ardour/ardour_ui.cc b/gtk2_ardour/ardour_ui.cc
index 97726cd..55c56e6 100644
--- a/gtk2_ardour/ardour_ui.cc
+++ b/gtk2_ardour/ardour_ui.cc
@@ -187,12 +187,12 @@ ARDOUR_UI::ARDOUR_UI (int *argcp, char **argvp[], const char* localedir)
 	, speaker_config_window (X_("speaker-config"), _("Speaker Configuration"))
 	, theme_manager (X_("theme-manager"), _("Theme Manager"))
 	, key_editor (X_("key-editor"), _("Key Bindings"))
-	, rc_option_editor (X_("rc-options-editor"), _("Preferences"))
+	, rc_option_editor (X_("rc-options-editor"), _("Preferences..."))
 	, add_route_dialog (X_("add-routes"), _("Add Tracks/Busses"))
-	, about (X_("about"), _("About"))
+	, about (X_("about"), _("About..."))
 	, location_ui (X_("locations"), _("Locations"))
 	, route_params (X_("inspector"), _("Tracks and Busses"))
-	, session_option_editor (X_("session-options-editor"), _("Properties"), boost::bind (&ARDOUR_UI::create_session_option_editor, this))
+	, session_option_editor (X_("session-options-editor"), _("Properties..."), boost::bind (&ARDOUR_UI::create_session_option_editor, this))
 	, add_video_dialog (X_("add-video"), _("Add Tracks/Busses"), boost::bind (&ARDOUR_UI::create_add_video_dialog, this))
 	, bundle_manager (X_("bundle-manager"), _("Bundle Manager"), boost::bind (&ARDOUR_UI::create_bundle_manager, this))
 	, big_clock_window (X_("big-clock"), _("Big Clock"), boost::bind (&ARDOUR_UI::create_big_clock_window, this))
diff --git a/gtk2_ardour/ardour_ui_ed.cc b/gtk2_ardour/ardour_ui_ed.cc
index 6c05057..4d64db8 100644
--- a/gtk2_ardour/ardour_ui_ed.cc
+++ b/gtk2_ardour/ardour_ui_ed.cc
@@ -132,13 +132,13 @@ ARDOUR_UI::install_actions ()
 	ActionManager::session_sensitive_actions.push_back (act);
 	ActionManager::write_sensitive_actions.push_back (act);
 
-	act = ActionManager::register_action (main_actions, X_("OpenVideo"), _("Open Video"),
+	act = ActionManager::register_action (main_actions, X_("OpenVideo"), _("Open Video..."),
 					      sigc::bind (sigc::mem_fun(*this, &ARDOUR_UI::add_video), (Gtk::Window*) 0));
 	ActionManager::session_sensitive_actions.push_back (act);
 	act = ActionManager::register_action (main_actions, X_("CloseVideo"), _("Remove Video"),
 					      sigc::mem_fun (*this, &ARDOUR_UI::remove_video));
 	act->set_sensitive (false);
-	act = ActionManager::register_action (main_actions, X_("ExportVideo"), _("Export To Video File"),
+	act = ActionManager::register_action (main_actions, X_("ExportVideo"), _("Export To Video File..."),
 					      sigc::mem_fun (*editor, &PublicEditor::export_video));
 	ActionManager::session_sensitive_actions.push_back (act);
 
@@ -233,10 +233,10 @@ ARDOUR_UI::install_actions ()
 
 	act = ActionManager::register_action (common_actions, X_("NewMIDITracer"), _("MIDI Tracer"), sigc::mem_fun(*this, &ARDOUR_UI::new_midi_tracer_window));
 	ActionManager::session_sensitive_actions.push_back (act);
-	ActionManager::register_action (common_actions, X_("Chat"), _("Chat"),  sigc::mem_fun(*this, &ARDOUR_UI::launch_chat));
+	ActionManager::register_action (common_actions, X_("Chat"), _("Chat (Browser)"),  sigc::mem_fun(*this, &ARDOUR_UI::launch_chat));
 	/** TRANSLATORS: This is `Manual' in the sense of an instruction book that tells a user how to use Ardour */
-	ActionManager::register_action (common_actions, X_("Manual"), S_("Help|Manual"),  mem_fun(*this, &ARDOUR_UI::launch_manual));
-	ActionManager::register_action (common_actions, X_("Reference"), _("Reference"),  mem_fun(*this, &ARDOUR_UI::launch_reference));
+	ActionManager::register_action (common_actions, X_("Manual"), S_("Help (Browser)|Manual (Browser)"),  mem_fun(*this, &ARDOUR_UI::launch_manual));
+	ActionManager::register_action (common_actions, X_("Reference"), _("Reference (Browser)"),  mem_fun(*this, &ARDOUR_UI::launch_reference));
 
 	act = ActionManager::register_action (common_actions, X_("Save"), _("Save"),  sigc::bind (sigc::mem_fun(*this, &ARDOUR_UI::save_state), string(""), false));
 	ActionManager::session_sensitive_actions.push_back (act);
diff --git a/gtk2_ardour/editor_actions.cc b/gtk2_ardour/editor_actions.cc
index a5e2e8a..a1ff2b4 100644
--- a/gtk2_ardour/editor_actions.cc
+++ b/gtk2_ardour/editor_actions.cc
@@ -359,7 +359,7 @@ Editor::register_actions ()
 
 	ActionManager::register_toggle_action (editor_actions, "toggle-stationary-playhead", _("Stationary Playhead"), (mem_fun(*this, &Editor::toggle_stationary_playhead)));
 
-	act = reg_sens (editor_actions, "insert-time", _("Insert Time"), (sigc::mem_fun(*this, &Editor::do_insert_time)));
+	act = reg_sens (editor_actions, "insert-time", _("Insert Time..."), (sigc::mem_fun(*this, &Editor::do_insert_time)));
 	ActionManager::track_selection_sensitive_actions.push_back (act);
 
 	act = reg_sens (editor_actions, "toggle-track-active", _("Toggle Active"), (sigc::mem_fun(*this, &Editor::toggle_tracks_active)));
@@ -649,7 +649,7 @@ Editor::register_actions ()
 
 	/* the next two are duplicate items with different names for use in two different contexts */
 
-	act = reg_sens (editor_actions, X_("addExistingAudioFiles"), _("Import"), sigc::mem_fun (*this, &Editor::external_audio_dialog));
+	act = reg_sens (editor_actions, X_("addExistingAudioFiles"), _("Import..."), sigc::mem_fun (*this, &Editor::external_audio_dialog));
 	ActionManager::write_sensitive_actions.push_back (act);
 
 	act = reg_sens (editor_actions, X_("addExternalAudioToRegionList"), _("Import to Region List..."), sigc::bind (sigc::mem_fun(*this, &Editor::add_external_audio_action), ImportAsRegion));
-- 
1.7.9.5

tom_

2013-08-15 16:00

reporter   ~0015261

handling via github / pull requests to keep current

Issue History

Date Modified Username Field Change
2013-08-08 18:43 tom_ New Issue
2013-08-08 18:43 tom_ File Added: menu_labels_points_postfix.patch
2013-08-15 16:00 tom_ Note Added: 0015261
2013-08-15 16:00 tom_ Status new => closed
2013-08-15 16:00 tom_ Resolution open => won't fix