View Issue Details

IDProjectCategoryView StatusLast Update
0005576ardourbugspublic2014-11-15 09:18
Reporterzth Assigned To 
PrioritynormalSeverityminorReproducibilityalways
Status feedbackResolutionopen 
Summary0005576: Automation: copying and pasting automation doesn't work as expected
DescriptionLike the summary says, copying and pasting automation does not work as expected. The pasted automation ends up a looong way forward in the session, and it's not the same automation that was copied.

Reproduce by simply copying and pasting multiple points of automation.
TagsNo tags attached.

Activities

eastwind

2014-05-27 18:20

reporter   ~0015821

Same here.
Pasting occurs with some interpolation changing.

Points position changed while its copying in method cut_copy_clear_one.
I removed coord alignment and it has become to work normally.

I attached the patch with that changing. But, this breaks inserting in neighbor automations (from Levels to Pan and etc. (for me it doesn't look like necessary usage)). This behavior comes from strange AutomationLine::model_to_view_coord method, with TODO label.

2014-05-27 18:21

 

0001-Removed-unnecessary-alignment-of-envelope-automation.patch (934 bytes)   
From 7f1a5a9692b40413af504c56e7f1202e22940414 Mon Sep 17 00:00:00 2001
From: Artur Shaik <ashaihullin@gmail.com>
Date: Tue, 27 May 2014 23:51:05 +0600
Subject: [PATCH] Removed unnecessary alignment of envelope automation during
 copying it

---
 gtk2_ardour/automation_time_axis.cc | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/gtk2_ardour/automation_time_axis.cc b/gtk2_ardour/automation_time_axis.cc
index 08690cd..4687524 100644
--- a/gtk2_ardour/automation_time_axis.cc
+++ b/gtk2_ardour/automation_time_axis.cc
@@ -956,13 +956,4 @@ AutomationTimeAxisView::cut_copy_clear_one (AutomationLine& line, Selection& sel
 		break;
 	}
 
-	if (what_we_got) {
-		for (AutomationList::iterator x = what_we_got->begin(); x != what_we_got->end(); ++x) {
-			double when = (*x)->when;
-			double val  = (*x)->value;
-			line.model_to_view_coord (when, val);
-			(*x)->when = when;
-			(*x)->value = val;
-		}
-	}
 }
-- 
1.8.4.5

drobilla

2014-11-15 09:18

developer   ~0015984

Possibly fixed, during testing of 31acd96384b930de928aa8c7969336ba3401bbed I didn't see this issue.

Issue History

Date Modified Username Field Change
2013-07-11 11:10 zth New Issue
2014-05-27 18:20 eastwind Note Added: 0015821
2014-05-27 18:21 eastwind File Added: 0001-Removed-unnecessary-alignment-of-envelope-automation.patch
2014-11-15 09:18 drobilla Note Added: 0015984
2014-11-15 09:18 drobilla Status new => feedback