View Issue Details

IDProjectCategoryView StatusLast Update
0005508ardourtranslationpublic2013-05-30 19:38
Reporterprokoudine Assigned To 
PrioritynormalSeveritytrivialReproducibilityalways
Status closedResolutionfixed 
Summary0005508: Not all MIDI channel messages marked for translation
DescriptionThe attached Git formatted patch marks a few forgotten messages for translation in the MIDI Channel Selector dialog.
TagsNo tags attached.

Activities

2013-05-26 11:14

 

0001-Marked-forgotten-messages-for-translation.patch (2,416 bytes)   
From 727b224d45aa36712c9ef87965a2baf6536990dc Mon Sep 17 00:00:00 2001
From: Alexandre Prokoudine <alexandre.prokoudine@gmail.com>
Date: Sun, 26 May 2013 15:09:41 +0400
Subject: [PATCH] Marked forgotten messages for translation

---
 gtk2_ardour/midi_time_axis.cc | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/gtk2_ardour/midi_time_axis.cc b/gtk2_ardour/midi_time_axis.cc
index 535854f..6cdf63f 100644
--- a/gtk2_ardour/midi_time_axis.cc
+++ b/gtk2_ardour/midi_time_axis.cc
@@ -1485,13 +1485,13 @@ MidiTimeAxisView::playback_channel_mode_changed ()
 {
 	switch (midi_track()->get_playback_channel_mode()) {
 	case AllChannels:
-		_playback_channel_status.set_markup (string_compose ("<b>%1</b>: <i>%2</i>", _("Play"), ("all")));
+		_playback_channel_status.set_markup (string_compose ("<b>%1</b>: <i>%2</i>", _("Play"), _("all")));
 		break;
 	case FilterChannels:
-		_playback_channel_status.set_markup (string_compose ("<b>%1</b>: <i>%2</i>", _("Play"), ("some")));
+		_playback_channel_status.set_markup (string_compose ("<b>%1</b>: <i>%2</i>", _("Play"), _("some")));
 		break;
 	case ForceChannel:
-		_playback_channel_status.set_markup (string_compose ("<b>%1</b>: <i>%2>%3</i>", _("Play"), ("all"), ffs (midi_track()->get_playback_channel_mask())));
+		_playback_channel_status.set_markup (string_compose ("<b>%1</b>: <i>%2>%3</i>", _("Play"), _("all"), ffs (midi_track()->get_playback_channel_mask())));
 		break;
 	}
 }
@@ -1501,13 +1501,13 @@ MidiTimeAxisView::capture_channel_mode_changed ()
 {
 	switch (midi_track()->get_capture_channel_mode()) {
 	case AllChannels:
-		_capture_channel_status.set_markup (string_compose ("<b>%1</b>: <i>%2</i>", _("Rec"), ("all")));
+		_capture_channel_status.set_markup (string_compose ("<b>%1</b>: <i>%2</i>", _("Rec"), _("all")));
 		break;
 	case FilterChannels:
-		_capture_channel_status.set_markup (string_compose ("<b>%1</b>: <i>%2</i>", _("Rec"), ("some")));
+		_capture_channel_status.set_markup (string_compose ("<b>%1</b>: <i>%2</i>", _("Rec"), _("some")));
 		break;
 	case ForceChannel:
-		_capture_channel_status.set_markup (string_compose ("<b>%1</b>: <i>%2>%3</i>", _("Rec"), ("all"), ffs (midi_track()->get_capture_channel_mask())));
+		_capture_channel_status.set_markup (string_compose ("<b>%1</b>: <i>%2>%3</i>", _("Rec"), _("all"), ffs (midi_track()->get_capture_channel_mask())));
 		break;
 	}
 }
-- 
1.8.1.2

x42

2013-05-30 19:38

administrator   ~0014948

applied in 3.1-89-g7ab2569

Issue History

Date Modified Username Field Change
2013-05-26 11:14 prokoudine New Issue
2013-05-26 11:14 prokoudine File Added: 0001-Marked-forgotten-messages-for-translation.patch
2013-05-30 19:38 x42 Note Added: 0014948
2013-05-30 19:38 x42 Status new => closed
2013-05-30 19:38 x42 Resolution open => fixed