View Issue Details

IDProjectCategoryView StatusLast Update
0005322ardourtranslationpublic2020-04-19 20:16
Reporterprokoudine Assigned Topaul  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Summary0005322: More forgotten translatable messages
DescriptionThe attached patch fixes the lack of several user-visible messages in PO files.
TagsNo tags attached.

Activities

2013-02-02 13:55

 

a3-2013-02-02-i18n.patch (4,016 bytes)   
--- ardour3/gtk2_ardour/monitor_section.cc	2013-01-19 02:12:51.376438154 +0400
+++ ardour3-2013-02-02/gtk2_ardour/monitor_section.cc	2013-02-02 17:03:42.587959273 +0400
@@ -675,22 +675,22 @@
         monitor_actions = ActionGroup::create (X_("Monitor"));
 	ActionManager::add_action_group (monitor_actions);
 
-        ActionManager::register_toggle_action (monitor_actions, "monitor-mono", "", "Switch monitor to mono",
+        ActionManager::register_toggle_action (monitor_actions, "monitor-mono", "", _("Switch monitor to mono"),
                                                sigc::mem_fun (*this, &MonitorSection::mono));
 
-        ActionManager::register_toggle_action (monitor_actions, "monitor-cut-all", "", "Cut monitor",
+        ActionManager::register_toggle_action (monitor_actions, "monitor-cut-all", "", _("Cut monitor"),
                                                sigc::mem_fun (*this, &MonitorSection::cut_all));
 
-        ActionManager::register_toggle_action (monitor_actions, "monitor-dim-all", "", "Dim monitor",
+        ActionManager::register_toggle_action (monitor_actions, "monitor-dim-all", "", _("Dim monitor"),
                                                sigc::mem_fun (*this, &MonitorSection::dim_all));
 
-        act = ActionManager::register_toggle_action (monitor_actions, "toggle-exclusive-solo", "", "Toggle exclusive solo mode",
+        act = ActionManager::register_toggle_action (monitor_actions, "toggle-exclusive-solo", "", _("Toggle exclusive solo mode"),
                                                sigc::mem_fun (*this, &MonitorSection::toggle_exclusive_solo));
 
         Glib::RefPtr<ToggleAction> tact = Glib::RefPtr<ToggleAction>::cast_dynamic(act);
         tact->set_active (Config->get_exclusive_solo());
 
-        act = ActionManager::register_toggle_action (monitor_actions, "toggle-mute-overrides-solo", "", "Toggle mute overrides solo mode",
+        act = ActionManager::register_toggle_action (monitor_actions, "toggle-mute-overrides-solo", "", _("Toggle mute overrides solo mode"),
                                                      sigc::mem_fun (*this, &MonitorSection::toggle_mute_overrides_solo));
 
         tact = Glib::RefPtr<ToggleAction>::cast_dynamic(act);
@@ -727,11 +727,11 @@
         Glib::RefPtr<ActionGroup> solo_actions = ActionGroup::create (X_("Solo"));
         RadioAction::Group solo_group;
 
-        ActionManager::register_radio_action (solo_actions, solo_group, "solo-use-in-place", "", "In-place solo",
+        ActionManager::register_radio_action (solo_actions, solo_group, "solo-use-in-place", "", _("In-place solo"),
                                               sigc::mem_fun (*this, &MonitorSection::solo_use_in_place));
-        ActionManager::register_radio_action (solo_actions, solo_group, "solo-use-afl", "", "After Fade Listen (AFL) solo",
+        ActionManager::register_radio_action (solo_actions, solo_group, "solo-use-afl", "", _("After Fade Listen (AFL) solo"),
                                               sigc::mem_fun (*this, &MonitorSection::solo_use_afl));
-        ActionManager::register_radio_action (solo_actions, solo_group, "solo-use-pfl", "", "Pre Fade Listen (PFL) solo",
+        ActionManager::register_radio_action (solo_actions, solo_group, "solo-use-pfl", "", _("Pre Fade Listen (PFL) solo"),
                                               sigc::mem_fun (*this, &MonitorSection::solo_use_pfl));
 
 	ActionManager::add_action_group (solo_actions);

--- ardour3/gtk2_ardour/stereo_panner.cc  2013-01-03 15:27:48.404229100 +0400
+++ ardour3-2013-02-02/gtk2_ardour/stereo_panner.cc 2013-02-02 15:20:12.112143892 +0400
@@ -105,7 +105,7 @@
  */
 
  char buf[64];
- snprintf (buf, sizeof (buf), "L:%3d R:%3d Width:%d%%", (int) rint (100.0 * (1.0 - pos)),
+ snprintf (buf, sizeof (buf), _("L:%3d R:%3d Width:%d%%"), (int) rint (100.0 * (1.0 - pos)),
            (int) rint (100.0 * pos),
            (int) floor (100.0 * width_control->get_value()));
  _tooltip.set_tip (buf);
a3-2013-02-02-i18n.patch (4,016 bytes)   

2013-02-02 14:42

 

a3-2013-02-02-i18n_upd.patch (4,475 bytes)   
--- ardour3/gtk2_ardour/monitor_section.cc	2013-01-19 02:12:51.376438154 +0400
+++ ardour3-2013-02-02/gtk2_ardour/monitor_section.cc	2013-02-02 17:03:42.587959273 +0400
@@ -675,22 +675,22 @@
         monitor_actions = ActionGroup::create (X_("Monitor"));
 	ActionManager::add_action_group (monitor_actions);
 
-        ActionManager::register_toggle_action (monitor_actions, "monitor-mono", "", "Switch monitor to mono",
+        ActionManager::register_toggle_action (monitor_actions, "monitor-mono", "", _("Switch monitor to mono"),
                                                sigc::mem_fun (*this, &MonitorSection::mono));
 
-        ActionManager::register_toggle_action (monitor_actions, "monitor-cut-all", "", "Cut monitor",
+        ActionManager::register_toggle_action (monitor_actions, "monitor-cut-all", "", _("Cut monitor"),
                                                sigc::mem_fun (*this, &MonitorSection::cut_all));
 
-        ActionManager::register_toggle_action (monitor_actions, "monitor-dim-all", "", "Dim monitor",
+        ActionManager::register_toggle_action (monitor_actions, "monitor-dim-all", "", _("Dim monitor"),
                                                sigc::mem_fun (*this, &MonitorSection::dim_all));
 
-        act = ActionManager::register_toggle_action (monitor_actions, "toggle-exclusive-solo", "", "Toggle exclusive solo mode",
+        act = ActionManager::register_toggle_action (monitor_actions, "toggle-exclusive-solo", "", _("Toggle exclusive solo mode"),
                                                sigc::mem_fun (*this, &MonitorSection::toggle_exclusive_solo));
 
         Glib::RefPtr<ToggleAction> tact = Glib::RefPtr<ToggleAction>::cast_dynamic(act);
         tact->set_active (Config->get_exclusive_solo());
 
-        act = ActionManager::register_toggle_action (monitor_actions, "toggle-mute-overrides-solo", "", "Toggle mute overrides solo mode",
+        act = ActionManager::register_toggle_action (monitor_actions, "toggle-mute-overrides-solo", "", _("Toggle mute overrides solo mode"),
                                                      sigc::mem_fun (*this, &MonitorSection::toggle_mute_overrides_solo));
 
         tact = Glib::RefPtr<ToggleAction>::cast_dynamic(act);
@@ -727,11 +727,11 @@
         Glib::RefPtr<ActionGroup> solo_actions = ActionGroup::create (X_("Solo"));
         RadioAction::Group solo_group;
 
-        ActionManager::register_radio_action (solo_actions, solo_group, "solo-use-in-place", "", "In-place solo",
+        ActionManager::register_radio_action (solo_actions, solo_group, "solo-use-in-place", "", _("In-place solo"),
                                               sigc::mem_fun (*this, &MonitorSection::solo_use_in_place));
-        ActionManager::register_radio_action (solo_actions, solo_group, "solo-use-afl", "", "After Fade Listen (AFL) solo",
+        ActionManager::register_radio_action (solo_actions, solo_group, "solo-use-afl", "", _("After Fade Listen (AFL) solo"),
                                               sigc::mem_fun (*this, &MonitorSection::solo_use_afl));
-        ActionManager::register_radio_action (solo_actions, solo_group, "solo-use-pfl", "", "Pre Fade Listen (PFL) solo",
+        ActionManager::register_radio_action (solo_actions, solo_group, "solo-use-pfl", "", _("Pre Fade Listen (PFL) solo"),
                                               sigc::mem_fun (*this, &MonitorSection::solo_use_pfl));
 
 	ActionManager::add_action_group (solo_actions);

--- ardour3/gtk2_ardour/mono_panner.cc  2012-12-12 00:27:58.783633364 +0400
+++ ardour3-2013-01-24/gtk2_ardour/mono_panner.cc 2013-02-02 18:16:23.311829644 +0400
@@ -98,7 +98,7 @@
         */
 
         char buf[64];
-        snprintf (buf, sizeof (buf), "L:%3d R:%3d",
+        snprintf (buf, sizeof (buf), _("L:%3d R:%3d"),
                   (int) rint (100.0 * (1.0 - pos)),
                   (int) rint (100.0 * pos));
         _tooltip.set_tip (buf);

--- ardour3/gtk2_ardour/stereo_panner.cc  2013-01-03 15:27:48.404229100 +0400
+++ ardour3-2013-02-02/gtk2_ardour/stereo_panner.cc 2013-02-02 15:20:12.112143892 +0400
@@ -105,7 +105,7 @@
  */
 
  char buf[64];
- snprintf (buf, sizeof (buf), "L:%3d R:%3d Width:%d%%", (int) rint (100.0 * (1.0 - pos)),
+ snprintf (buf, sizeof (buf), _("L:%3d R:%3d Width:%d%%"), (int) rint (100.0 * (1.0 - pos)),
            (int) rint (100.0 * pos),
            (int) floor (100.0 * width_control->get_value()));
  _tooltip.set_tip (buf);
a3-2013-02-02-i18n_upd.patch (4,475 bytes)   

prokoudine

2013-02-02 14:43

reporter   ~0014623

Patch updated to include the fix for mono panner.

paul

2013-02-05 18:25

administrator   ~0014627

cmmitted, rev 14051. thanks!

system

2020-04-19 20:16

developer   ~0023188

Issue has been closed automatically, by Trigger Close Plugin.
Feel free to re-open with additional information if you think the issue is not resolved.

Issue History

Date Modified Username Field Change
2013-02-02 13:55 prokoudine New Issue
2013-02-02 13:55 prokoudine File Added: a3-2013-02-02-i18n.patch
2013-02-02 14:42 prokoudine File Added: a3-2013-02-02-i18n_upd.patch
2013-02-02 14:43 prokoudine Note Added: 0014623
2013-02-05 18:25 paul cost => 0.00
2013-02-05 18:25 paul Note Added: 0014627
2013-02-05 18:25 paul Status new => resolved
2013-02-05 18:25 paul Resolution open => fixed
2013-02-05 18:25 paul Assigned To => paul
2020-04-19 20:16 system Note Added: 0023188
2020-04-19 20:16 system Status resolved => closed