View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0005266 | ardour | bugs | public | 2013-01-12 22:36 | 2020-04-19 20:16 |
| Reporter | royvegard | Assigned To | paul | ||
| Priority | normal | Severity | crash | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Summary | 0005266: [PATCH] Fix seg fault when toggling mute, dim, solo or inv for last channel in monitor section | ||||
| Description | - Seg fault when clicking mute, dim, solo or inv for the last channel in the monitor section. - Tooltip for first channel says channel 2, tooltip for second channel says channel 3, etc. Attached patch fixes thes bug. | ||||
| Tags | No tags attached. | ||||
|
2013-01-12 22:38
|
0005266.patch (2,249 bytes)
Index: gtk2_ardour/monitor_section.cc
===================================================================
--- gtk2_ardour/monitor_section.cc (revision 13837)
+++ gtk2_ardour/monitor_section.cc (working copy)
@@ -682,22 +682,22 @@
for (uint32_t chn = 1; chn <= 16; ++chn) {
- action_name = string_compose (X_("monitor-cut-%1"), chn-1);
+ action_name = string_compose (X_("monitor-cut-%1"), chn);
action_descr = string_compose (_("Cut monitor channel %1"), chn);
ActionManager::register_toggle_action (monitor_actions, action_name.c_str(), "", action_descr.c_str(),
sigc::bind (sigc::mem_fun (*this, &MonitorSection::cut_channel), chn));
- action_name = string_compose (X_("monitor-dim-%1"), chn-1);
+ action_name = string_compose (X_("monitor-dim-%1"), chn);
action_descr = string_compose (_("Dim monitor channel %1"), chn);
ActionManager::register_toggle_action (monitor_actions, action_name.c_str(), "", action_descr.c_str(),
sigc::bind (sigc::mem_fun (*this, &MonitorSection::dim_channel), chn));
- action_name = string_compose (X_("monitor-solo-%1"), chn-1);
+ action_name = string_compose (X_("monitor-solo-%1"), chn);
action_descr = string_compose (_("Solo monitor channel %1"), chn);
ActionManager::register_toggle_action (monitor_actions, action_name.c_str(), "", action_descr.c_str(),
sigc::bind (sigc::mem_fun (*this, &MonitorSection::solo_channel), chn));
- action_name = string_compose (X_("monitor-invert-%1"), chn-1);
+ action_name = string_compose (X_("monitor-invert-%1"), chn);
action_descr = string_compose (_("Invert monitor channel %1"), chn);
ActionManager::register_toggle_action (monitor_actions, action_name.c_str(), "", action_descr.c_str(),
sigc::bind (sigc::mem_fun (*this, &MonitorSection::invert_channel), chn)); |
|
|
committed rev 13838. thanks for fixing up my mistake(s). |
|
|
Issue has been closed automatically, by Trigger Close Plugin. Feel free to re-open with additional information if you think the issue is not resolved. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2013-01-12 22:36 | royvegard | New Issue | |
| 2013-01-12 22:38 | royvegard | File Added: 0005266.patch | |
| 2013-01-14 13:49 | paul | cost | => 0.00 |
| 2013-01-14 13:49 | paul | Note Added: 0014469 | |
| 2013-01-14 13:49 | paul | Status | new => resolved |
| 2013-01-14 13:49 | paul | Resolution | open => fixed |
| 2013-01-14 13:49 | paul | Assigned To | => paul |
| 2020-04-19 20:16 | system | Note Added: 0023177 | |
| 2020-04-19 20:16 | system | Status | resolved => closed |
