View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0005200 | ardour | bugs | public | 2012-11-30 16:07 | 2015-09-18 15:27 |
| Reporter | colinf | Assigned To | paul | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Summary | 0005200: Clocks in region properties always start off showing samples | ||||
| Description | The clocks in the region properties window always start off in samples mode when a session is opened, regardless of the format of the secondary clock. Moreover, if you do change the format via right-click in the region properties window, it is changed only for that particular region: other regions remain in samples mode. | ||||
| Tags | No tags attached. | ||||
|
|
Also (this may be a separate bug), the clocks in the region properties window cannot be edited until they've been right-clicked on once to pop up the menu (though it's not necessary to actually change the format). |
|
|
Seems like the clocks in the Locations window and editor sidebar also start off in samples mode in a new session, though they do at least store their mode in the session file, so maybe this doesn't matter quite so much. |
|
|
Hmm, and I can't reproduce the region properties clocks not being editable now... |
|
2013-01-07 19:31
|
region+location-use-secondary-clock-mode.patch (1,319 bytes)
Index: gtk2_ardour/region_editor.cc
===================================================================
--- gtk2_ardour/region_editor.cc (revision 13795)
+++ gtk2_ardour/region_editor.cc (working copy)
@@ -30,6 +30,7 @@
#include "ardour_ui.h"
#include "clock_group.h"
+#include "main_clock.h"
#include "gui_thread.h"
#include "region_editor.h"
#include "utils.h"
@@ -60,7 +61,7 @@
{
set_session (s);
- _clock_group->set_clock_mode (AudioClock::Frames);
+ _clock_group->set_clock_mode (ARDOUR_UI::instance()->secondary_clock->mode());
_clock_group->add (position_clock);
_clock_group->add (end_clock);
_clock_group->add (length_clock);
Index: gtk2_ardour/location_ui.cc
===================================================================
--- gtk2_ardour/location_ui.cc (revision 13795)
+++ gtk2_ardour/location_ui.cc (working copy)
@@ -27,6 +27,7 @@
#include "ardour_ui.h"
#include "clock_group.h"
+#include "main_clock.h"
#include "gui_thread.h"
#include "keyboard.h"
#include "location_ui.h"
@@ -1120,7 +1121,7 @@
XMLProperty* p = node->property (X_("clock-mode"));
if (!p) {
- return AudioClock::Frames;
+ return ARDOUR_UI::instance()->secondary_clock->mode();
}
return (AudioClock::Mode) string_2_enum (p->value (), AudioClock::Mode);
|
|
|
I made a simple patch to make clocks in the region properties use the secondary clock mode, and in the locations window to default to that mode if no other has been set. Is this the right thing to do? |
|
|
applied, rev 13806. thanks! |
|
|
Closing old issues reported by me: these have long since been fixed. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2012-11-30 16:07 | colinf | New Issue | |
| 2012-11-30 16:10 | colinf | Note Added: 0014306 | |
| 2012-12-14 16:09 | colinf | Note Added: 0014354 | |
| 2012-12-14 16:11 | colinf | Note Added: 0014355 | |
| 2013-01-07 19:31 | colinf | File Added: region+location-use-secondary-clock-mode.patch | |
| 2013-01-07 19:33 | colinf | Note Added: 0014443 | |
| 2013-01-08 00:22 | paul | cost | => 0.00 |
| 2013-01-08 00:22 | paul | Note Added: 0014446 | |
| 2013-01-08 00:22 | paul | Status | new => resolved |
| 2013-01-08 00:22 | paul | Resolution | open => fixed |
| 2013-01-08 00:22 | paul | Assigned To | => paul |
| 2015-09-18 15:27 | colinf | Note Added: 0017305 | |
| 2015-09-18 15:27 | colinf | Status | resolved => closed |
