View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0005086 | ardour | bugs | public | 2012-09-02 17:05 | 2020-04-19 20:16 |
| Reporter | x42 | Assigned To | paul | ||
| Priority | normal | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Target Version | 3.0 | ||||
| Summary | 0005086: old session is not saved when creating a new session | ||||
| Description | 1) load a session 2) do some modifications 3) Choose Session->New from the menu. The modifications made during (2) are not saved. There is no dialog to ask if to safe them, either. | ||||
| Additional Information | It actually looks like the old session is actually never closed. The _session handle is simply replaced with a new one. | ||||
| Tags | No tags attached. | ||||
|
|
Works for me; I do Session->New, specify the details for the new session and then I get asked what I want to do with the old one. |
|
|
here it needs attached patch to do so. |
|
2012-10-17 22:40
|
a3_fixbug5086.diff (670 bytes)
commit ec7a3c7102b50c6c3cc54afe209bc1eaf4b7cda0
Author: Robin Gareus <robin@gareus.org>
Date: Mon Sep 3 17:23:27 2012 +0200
fix http://tracker.ardour.org/view.php?id=5086
diff --git a/gtk2_ardour/ardour_ui.cc b/gtk2_ardour/ardour_ui.cc
index aa9b909..ee85c82 100644
--- a/gtk2_ardour/ardour_ui.cc
+++ b/gtk2_ardour/ardour_ui.cc
@@ -2464,6 +2464,11 @@ ARDOUR_UI::get_session_parameters (bool quit_on_cancel, bool should_be_new, stri
int ret = -1;
bool likely_new = false;
+ if (_session) {
+ unload_session (false);
+ ARDOUR_COMMAND_LINE::session_name = "";
+ }
+
if (!load_template.empty()) {
should_be_new = true;
template_name = load_template;
|
|
|
the patch saves the existing session at the beginning of gathering information about the new session. the code currently wouldn't do that until a new session is actually about to be loaded. it seems right to me that we would ask about the existing session first, if its dirty. the patch needs a slight reworking for this to happen in the right way. |
|
|
rev 13306 |
|
|
Issue has been closed automatically, by Trigger Close Plugin. Feel free to re-open with additional information if you think the issue is not resolved. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2012-09-02 17:05 | x42 | New Issue | |
| 2012-09-07 23:02 | cth103 | cost | => 0.00 |
| 2012-09-07 23:02 | cth103 | Target Version | => 3.0 |
| 2012-09-08 00:16 | cth103 | Note Added: 0014003 | |
| 2012-10-17 22:39 | x42 | Note Added: 0014085 | |
| 2012-10-17 22:40 | x42 | File Added: a3_fixbug5086.diff | |
| 2012-10-18 13:28 | paul | Note Added: 0014093 | |
| 2012-10-18 13:43 | paul | Note Added: 0014094 | |
| 2012-10-18 13:43 | paul | Status | new => resolved |
| 2012-10-18 13:43 | paul | Resolution | open => fixed |
| 2012-10-18 13:43 | paul | Assigned To | => paul |
| 2020-04-19 20:16 | system | Note Added: 0023143 | |
| 2020-04-19 20:16 | system | Status | resolved => closed |
