View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0005068 | ardour | bugs | public | 2012-08-07 09:15 | 2020-04-19 20:16 |
| Reporter | wferi | Assigned To | cth103 | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Summary | 0005068: New Session dialog: the "more options" checkbox does not give more options | ||||
| Description | When creating a new session, one can tick the checkbox labeled "I'd like more options for this session", but it does not display more options, only makes the dialog window taller. The place thus created for more options remains empty. | ||||
| Additional Information | SVN revision: 13053 | ||||
| Tags | No tags attached. | ||||
|
|
Oh, ticking the checkbox actually changes the "Open" button to "Forward", so more options become available in the next dialog box, but then enlarging the current box is superfluous and misleading. |
|
|
Maybe that 'more options' tick box shouldn't be there at all and the next page should have an 'advanced' button that expands that page. Would make more sense if the 'more options' appear on the next page anyway ! |
|
|
I don't think so, because if you don't tick 'more options', there's no next page at all: the new session opens straight up. The question is whether the 'more options' should be a separate dialog or rather an extension of the common one. I'd prefer the latter, but I'm also OK with the former, but then Ardour shouldn't enlarge the common dialog on ticking that option. |
|
2012-08-20 10:57
|
no_enlarge_with_more_options.patch (926 bytes)
diff --git a/gtk2_ardour/startup.cc b/gtk2_ardour/startup.cc
index 7f7dbe8..b17270c 100644
--- a/gtk2_ardour/startup.cc
+++ b/gtk2_ardour/startup.cc
@@ -1250,10 +1250,11 @@ ArdourStartup::setup_more_options_page ()
_limit_output_ports.signal_clicked().connect (sigc::mem_fun (*this, &ArdourStartup::limit_outputs_clicked));
_create_master_bus.signal_clicked().connect (sigc::mem_fun (*this, &ArdourStartup::master_bus_button_clicked));
- /* note that more_options_vbox is NOT visible by
- * default. this is entirely by design - this page
- * should be skipped unless explicitly requested.
+ /* note that more_options_vbox is "visible" by default even
+ * though it may not be displayed to the user, this is so the dialog
+ * doesn't resize.
*/
+ more_options_vbox.show_all ();
session_options_page_index = append_page (more_options_vbox);
set_page_title (more_options_vbox, _("Advanced Session Options"));
|
|
|
I've uploaded a patch that should fix the startup dialog so that it doesn't resize when more options are requested. At least on my system the size of the dialog still seems a bit strange(too narrow). It would be good to also ensure that the dialog doesn't ever have to resize and that it has a decent aspect ratio. |
|
|
Patch applied to SVN 13159; thanks! |
|
|
Issue has been closed automatically, by Trigger Close Plugin. Feel free to re-open with additional information if you think the issue is not resolved. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2012-08-07 09:15 | wferi | New Issue | |
| 2012-08-07 09:17 | wferi | Note Added: 0013967 | |
| 2012-08-07 09:36 | oofus | Note Added: 0013968 | |
| 2012-08-07 11:16 | wferi | Note Added: 0013969 | |
| 2012-08-20 10:57 | timbyr | File Added: no_enlarge_with_more_options.patch | |
| 2012-08-20 11:03 | timbyr | Note Added: 0013976 | |
| 2012-09-01 11:32 | cth103 | cost | => 0.00 |
| 2012-09-01 11:32 | cth103 | Note Added: 0013992 | |
| 2012-09-01 11:32 | cth103 | Status | new => resolved |
| 2012-09-01 11:32 | cth103 | Resolution | open => fixed |
| 2012-09-01 11:32 | cth103 | Assigned To | => cth103 |
| 2020-04-19 20:16 | system | Note Added: 0023139 | |
| 2020-04-19 20:16 | system | Status | resolved => closed |
