View Issue Details

IDProjectCategoryView StatusLast Update
0004936ardourbugspublic2020-04-19 20:16
Reporterseablade Assigned Topaul  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Target Version3.0 
Summary0004936: [PATCH] Mackie LED Ring Around Pots display Width Values is Wrong
DescriptionThe LED Ring around the VPots on the Mackie Control Universal doesn't show as accurate info as it should in my opinion, it has a simple math error that prevent it from ever showing the LED ring full, in fact over 90% it shows nothing at all. It also shows nothing when the width is negative, which it really should represent the negative width just the same, as it still has a width, it is just L/R reversed. This patch should fix both of these issues.
TagsNo tags attached.

Activities

2012-06-15 16:22

 

mackie_pot_led_patch.diff (773 bytes)   
Index: libs/surfaces/mackie/pot.cc
===================================================================
--- libs/surfaces/mackie/pot.cc	(revision 12515)
+++ libs/surfaces/mackie/pot.cc	(working copy)
@@ -47,11 +47,20 @@
 	
 	// Pot/LED mode
 	msg |=  (mode << 4);
+
+	/*
+	 * Even though a width value may be negative, there is
+	 * technically still width there, it is just reversed,
+	 * so make sure to show it on the LED ring appropriately.
+	 */
+	if (val < 0){
+	  val = val * -1;
+	}
 	
 	// val, but only if off hasn't explicitly been set
 	if (onoff) {
 		if (mode == spread) {
-			msg |=  (lrintf (val * 6) + 1) & 0x0f; // 0b00001111
+			msg |=  (lrintf (val * 6)) & 0x0f; // 0b00001111
 		} else {
 			msg |=  (lrintf (val * 10.0) + 1) & 0x0f; // 0b00001111
 		}
mackie_pot_led_patch.diff (773 bytes)   

paul

2012-06-16 03:10

administrator   ~0013550

committed rev 12379, thanks!

system

2020-04-19 20:16

developer   ~0023086

Issue has been closed automatically, by Trigger Close Plugin.
Feel free to re-open with additional information if you think the issue is not resolved.

Issue History

Date Modified Username Field Change
2012-06-15 16:22 seablade New Issue
2012-06-15 16:22 seablade File Added: mackie_pot_led_patch.diff
2012-06-15 16:22 seablade cost => 0.00
2012-06-15 16:22 seablade Status new => assigned
2012-06-15 16:22 seablade Assigned To => paul
2012-06-16 00:38 cth103 Target Version => 3.0
2012-06-16 03:10 paul Note Added: 0013550
2012-06-16 03:10 paul Status assigned => resolved
2012-06-16 03:10 paul Resolution open => fixed
2020-04-19 20:16 system Note Added: 0023086
2020-04-19 20:16 system Status resolved => closed