View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0004896 | ardour | bugs | public | 2012-05-29 13:35 | 2015-09-18 15:19 |
| Reporter | colinf | Assigned To | cth103 | ||
| Priority | normal | Severity | tweak | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Target Version | 3.0 | ||||
| Summary | 0004896: [PATCH] Region context sub-menus are disabled when not in object mode | ||||
| Description | When the mode is set to anything other than 'Select/Move Objects', although some of the region context sub-menus themselves ('Edit', 'Position', 'Trim', 'Layering', 'Ranges', 'Gain', 'Fades' and 'Duplicate') are active, all of of the items in all sub-menus are disabled. | ||||
| Tags | No tags attached. | ||||
|
2012-05-29 15:54
|
sensitise-region-context-menu-all-modes.patch (839 bytes)
Index: gtk2_ardour/editor_selection.cc
===================================================================
--- gtk2_ardour/editor_selection.cc (revision 12476)
+++ gtk2_ardour/editor_selection.cc (working copy)
@@ -1016,20 +1016,7 @@
void
Editor::sensitize_the_right_region_actions ()
{
- if ((mouse_mode == MouseRange) || (mouse_mode != MouseObject && _join_object_range_state == JOIN_OBJECT_RANGE_RANGE)) {
- sensitize_all_region_actions (false);
- if (!selection->time.empty()) {
- _region_actions->get_action("split-region")->set_sensitive (true);
- }
- return;
- } else if (mouse_mode != MouseObject) {
- sensitize_all_region_actions (false);
- return;
- }
-
- /* We get here if we are in Object mode */
-
RegionSelection rs = get_regions_from_selection_and_entered ();
sensitize_all_region_actions (!rs.empty ());
|
|
|
I can't see any reason why Editor::sensitize_the_right_region_actions () needs to care about the current mouse_mode. Deleting that check as per attached patch makes the region context sub-menus work for me in modes besides object. |
|
|
Applied to SVN 12601. Thanks! |
|
|
Closing old issues reported by me: these have long since been fixed. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2012-05-29 13:35 | colinf | New Issue | |
| 2012-05-29 15:54 | colinf | File Added: sensitise-region-context-menu-all-modes.patch | |
| 2012-05-29 15:59 | colinf | Note Added: 0013330 | |
| 2012-05-29 16:18 | colinf | Summary | Region context sub-menus are disabled when not in object mode => [PATCH] Region context sub-menus are disabled when not in object mode |
| 2012-05-29 16:41 | cth103 | cost | => 0.00 |
| 2012-05-29 16:41 | cth103 | Target Version | => 3.0 |
| 2012-06-08 12:33 | cth103 | Note Added: 0013417 | |
| 2012-06-08 12:33 | cth103 | Status | new => resolved |
| 2012-06-08 12:33 | cth103 | Resolution | open => fixed |
| 2012-06-08 12:33 | cth103 | Assigned To | => cth103 |
| 2015-09-18 15:19 | colinf | Note Added: 0017287 | |
| 2015-09-18 15:19 | colinf | Status | resolved => closed |
