View Issue Details

IDCategoryLast Update
0004875bugs2012-05-21 09:22
ReporterelfringAssigned Topaul 
Status resolvedResolutionwon't fix 
Product Version 
Fixed in Version 
Summary0004875: reserved identifier violation
DescriptionI would like to point out that identifiers like "__ardour_amp_h__" and "_AlignStyle" do not fit to the expected naming convention of the C++ language standard.

Would you like to adjust your selection for unique names?
Additional Information
TagsNo tags attached.



2012-05-21 09:22

administrator   ~0013269

We will accept patches for this but I consider the language standard hopelessly at odds with (a) common C and C++ programming habits over the last 30 years and (b) a probabilistic assessment of reality.

The chances of a compiler or another library definining __ardour_amp_h__ are vanishingly small. The chances of a compiler or another library defining an identifier with function scope and a name like _AlignStyle are even smaller.

Ardour's code is definitely not in line with the standard, but I am going to mark this as WONTFIX. Patches to change things will be cheerfully accepted.

Issue History

Date Modified Username Field Change
2012-05-13 09:27 elfring New Issue
2012-05-13 12:25 cth103 cost => 0.00
2012-05-13 12:25 cth103 Severity major => minor
2012-05-13 12:25 cth103 Status new => confirmed
2012-05-13 12:25 cth103 Target Version => 3.X
2012-05-21 09:22 paul Note Added: 0013269
2012-05-21 09:22 paul Status confirmed => resolved
2012-05-21 09:22 paul Resolution open => won't fix
2012-05-21 09:22 paul Assigned To => paul