0004825: Incorrect logical expression

ID	Project	Category	View Status	Date Submitted	Last Update

0004825	ardour	bugs	public	2012-04-05 00:47	2020-04-19 20:16

Reporter	ahurst	Assigned To	cth103
Priority	normal	Severity	trivial	Reproducibility	have not tried
Status	closed	Resolution	fixed
Product Version	3.0-beta3
Target Version	3.0

Summary	0004825: Incorrect logical expression
Description	Medium impact static analysis bug: Incorrect logical expression at: libs/ardour/session.cc:2993. Either need parenthesis "!(_state_of_the_state & InCleanup)" or use the bitwise-not operator "~".
Additional Information	*** Wrong operator. The "!" operator is logical and evaluates to "0" or "1", and the condition can never be true. 2993 if (!_state_of_the_state & InCleanup) { 2994 2995 /* save state so we don't end up with a session file 2996 referring to non-existent sources. 2997 */ 2998 2999 save_state (_current_snapshot_name); 3000 }
Tags	No tags attached.

Date Modified	Username	Field	Change
2012-04-05 00:47	ahurst	New Issue
2012-04-05 01:05	cth103	cost	=> 0.00
2012-04-05 01:05	cth103	Target Version	=> 3.0 beta4
2012-04-05 01:21	cth103	Note Added: 0013080
2012-04-05 01:21	cth103	Status	new => resolved
2012-04-05 01:21	cth103	Resolution	open => fixed
2012-04-05 01:21	cth103	Assigned To	=> cth103
2012-05-23 15:08	cth103	Target Version	3.0 beta4 => 3.0
2020-04-19 20:16	system	Note Added: 0023034
2020-04-19 20:16	system	Status	resolved => closed

cth103 2012-04-05 01:21 administrator ~0013080	SVN 11791.

system 2020-04-19 20:16 developer ~0023034	Issue has been closed automatically, by Trigger Close Plugin. Feel free to re-open with additional information if you think the issue is not resolved.