View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0004821 | ardour | bugs | public | 2012-04-05 00:26 | 2020-04-19 20:16 |
| Reporter | ahurst | Assigned To | cth103 | ||
| Priority | normal | Severity | major | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | ||
| Product Version | 3.0-beta3 | ||||
| Target Version | 3.0 | ||||
| Summary | 0004821: Using invalid iterator | ||||
| Description | Medium impact static analysis bug: Using iterator after invalidation at: libs/gtkmm2ext/gtkmm2ext/dndvbox.h:575. | ||||
| Additional Information | 570 void remove_from_selection (T* child) 571 { 572 typename std::list<T*>::iterator x = find (_selection.begin(), _selection.end(), child); 573 if (x != _selection.end()) { *** "erase" invalidates iterator "x". 574 _selection.erase (x); *** Using invalid iterator "x". 575 setup_child_state (*x); 576 } 577 } | ||||
| Tags | No tags attached. | ||||
|
2012-04-09 14:45
|
bug4821.patch (393 bytes)
Index: dndvbox.h
===================================================================
--- dndvbox.h (révision 11846)
+++ dndvbox.h (copie de travail)
@@ -571,8 +571,8 @@
{
typename std::list<T*>::iterator x = find (_selection.begin(), _selection.end(), child);
if (x != _selection.end()) {
+ setup_child_state (*x);
_selection.erase (x);
- setup_child_state (*x);
}
}
|
|
|
I am not sur for this patch but it can be a solution. |
|
|
Looks right to me. |
|
|
Not quite, because setup_child_state() checks out the selected state of its child, so the child must have been removed from the selected list first. Fixed in SVN 11892. |
|
|
Issue has been closed automatically, by Trigger Close Plugin. Feel free to re-open with additional information if you think the issue is not resolved. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2012-04-05 00:26 | ahurst | New Issue | |
| 2012-04-05 01:06 | cth103 | cost | => 0.00 |
| 2012-04-05 01:06 | cth103 | Target Version | => 3.0 beta4 |
| 2012-04-09 14:45 | epitech_user | File Added: bug4821.patch | |
| 2012-04-09 14:46 | epitech_user | Note Added: 0013095 | |
| 2012-04-09 22:29 | ahurst | Note Added: 0013099 | |
| 2012-04-11 10:32 | cth103 | Note Added: 0013110 | |
| 2012-04-11 10:32 | cth103 | Status | new => resolved |
| 2012-04-11 10:32 | cth103 | Resolution | open => fixed |
| 2012-04-11 10:32 | cth103 | Assigned To | => cth103 |
| 2012-05-23 15:08 | cth103 | Target Version | 3.0 beta4 => 3.0 |
| 2020-04-19 20:16 | system | Note Added: 0023030 | |
| 2020-04-19 20:16 | system | Status | resolved => closed |
