View Issue Details

IDProjectCategoryView StatusLast Update
0004819ardourbugspublic2020-04-19 20:16
Reporterahurst Assigned Tocth103  
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Product Version3.0-beta3 
Target Version3.0 
Summary0004819: Probably unintentional switch statement fall-through, probably causing MIDI weirdness
DescriptionMedium impact static analysis bug:

Missing break in switch at libs/ardour/midi_buffer:316.

Probably unintentional based on the rest of the structure.
Additional Information*** Missing break in switch. This case (value 192) is not terminated by a 'break' statement.
316 case MIDI_CMD_PGM_CHANGE:
317 switch (a & 0xf0) {
318 case MIDI_CMD_CONTROL:
319 break;
320 case MIDI_CMD_PGM_CHANGE:
321 case MIDI_CMD_NOTE_OFF:
322 case MIDI_CMD_NOTE_ON:
323 case MIDI_CMD_NOTE_PRESSURE:
324 case MIDI_CMD_CHANNEL_PRESSURE:
325 case MIDI_CMD_BENDER:
326 b_first = true;
327 }
328
*** The above case falls through to this one.
329 case MIDI_CMD_NOTE_OFF:
TagsNo tags attached.

Activities

cth103

2012-04-11 23:46

administrator   ~0013116

SVN 11925.

system

2020-04-19 20:16

developer   ~0023028

Issue has been closed automatically, by Trigger Close Plugin.
Feel free to re-open with additional information if you think the issue is not resolved.

Issue History

Date Modified Username Field Change
2012-04-05 00:21 ahurst New Issue
2012-04-05 01:06 cth103 cost => 0.00
2012-04-05 01:06 cth103 Target Version => 3.0 beta4
2012-04-11 23:46 cth103 Note Added: 0013116
2012-04-11 23:46 cth103 Status new => resolved
2012-04-11 23:46 cth103 Resolution open => fixed
2012-04-11 23:46 cth103 Assigned To => cth103
2012-05-23 15:08 cth103 Target Version 3.0 beta4 => 3.0
2020-04-19 20:16 system Note Added: 0023028
2020-04-19 20:16 system Status resolved => closed