View Issue Details

IDProjectCategoryView StatusLast Update
0004816ardourbugspublic2020-04-19 20:16
Reporterahurst Assigned Tocth103  
PrioritynormalSeveritytrivialReproducibilityhave not tried
Status closedResolutionfixed 
Product Version3.0-beta3 
Target Version3.0 
Summary0004816: Incorrect syntax in comparison
DescriptionMedium impact static analysis bug:

Statement with no effect at gtk2_ardour/theme_manager.cc:337.

Constant string pointer is always true. Copy and paste error.
Additional Information337 } else if (rcfile == "ardour3_ui_light.rc" || "ardour3_ui_light_sae.rc") {
TagsNo tags attached.

Activities

2012-04-10 13:55

 

bug_4816.patch (536 bytes)   
Index: gtk2_ardour/theme_manager.cc
===================================================================
--- gtk2_ardour/theme_manager.cc	(révision 11860)
+++ gtk2_ardour/theme_manager.cc	(copie de travail)
@@ -334,7 +334,7 @@
 
 	if (rcfile == "ardour3_ui_dark.rc" || rcfile == "ardour3_ui_dark_sae.rc") {
 		dark_button.set_active();
-	} else if (rcfile == "ardour3_ui_light.rc" || "ardour3_ui_light_sae.rc") {
+	} else if (rcfile == "ardour3_ui_light.rc" || rcfile == "ardour3_ui_light_sae.rc") {
 		light_button.set_active();
 	}
 
bug_4816.patch (536 bytes)   

epitech_user

2012-04-10 13:55

reporter   ~0013102

Here's the patch!

cth103

2012-04-11 10:08

administrator   ~0013107

Patch applied to SVN 11890. Thanks!

system

2020-04-19 20:16

developer   ~0023025

Issue has been closed automatically, by Trigger Close Plugin.
Feel free to re-open with additional information if you think the issue is not resolved.

Issue History

Date Modified Username Field Change
2012-04-05 00:13 ahurst New Issue
2012-04-05 01:07 cth103 cost => 0.00
2012-04-05 01:07 cth103 Target Version => 3.0 beta4
2012-04-05 01:07 cth103 Additional Information Updated
2012-04-10 13:55 epitech_user File Added: bug_4816.patch
2012-04-10 13:55 epitech_user Note Added: 0013102
2012-04-11 10:08 cth103 Note Added: 0013107
2012-04-11 10:08 cth103 Status new => resolved
2012-04-11 10:08 cth103 Resolution open => fixed
2012-04-11 10:08 cth103 Assigned To => cth103
2012-05-23 15:08 cth103 Target Version 3.0 beta4 => 3.0
2020-04-19 20:16 system Note Added: 0023025
2020-04-19 20:16 system Status resolved => closed