View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0004816 | ardour | bugs | public | 2012-04-05 00:13 | 2020-04-19 20:16 |
Reporter | ahurst | Assigned To | cth103 | ||
Priority | normal | Severity | trivial | Reproducibility | have not tried |
Status | closed | Resolution | fixed | ||
Product Version | 3.0-beta3 | ||||
Target Version | 3.0 | ||||
Summary | 0004816: Incorrect syntax in comparison | ||||
Description | Medium impact static analysis bug: Statement with no effect at gtk2_ardour/theme_manager.cc:337. Constant string pointer is always true. Copy and paste error. | ||||
Additional Information | 337 } else if (rcfile == "ardour3_ui_light.rc" || "ardour3_ui_light_sae.rc") { | ||||
Tags | No tags attached. | ||||
2012-04-10 13:55
|
bug_4816.patch (536 bytes)
Index: gtk2_ardour/theme_manager.cc =================================================================== --- gtk2_ardour/theme_manager.cc (révision 11860) +++ gtk2_ardour/theme_manager.cc (copie de travail) @@ -334,7 +334,7 @@ if (rcfile == "ardour3_ui_dark.rc" || rcfile == "ardour3_ui_dark_sae.rc") { dark_button.set_active(); - } else if (rcfile == "ardour3_ui_light.rc" || "ardour3_ui_light_sae.rc") { + } else if (rcfile == "ardour3_ui_light.rc" || rcfile == "ardour3_ui_light_sae.rc") { light_button.set_active(); } |
|
Here's the patch! |
|
Patch applied to SVN 11890. Thanks! |
|
Issue has been closed automatically, by Trigger Close Plugin. Feel free to re-open with additional information if you think the issue is not resolved. |
Date Modified | Username | Field | Change |
---|---|---|---|
2012-04-05 00:13 | ahurst | New Issue | |
2012-04-05 01:07 | cth103 | cost | => 0.00 |
2012-04-05 01:07 | cth103 | Target Version | => 3.0 beta4 |
2012-04-05 01:07 | cth103 | Additional Information Updated | |
2012-04-10 13:55 | epitech_user | File Added: bug_4816.patch | |
2012-04-10 13:55 | epitech_user | Note Added: 0013102 | |
2012-04-11 10:08 | cth103 | Note Added: 0013107 | |
2012-04-11 10:08 | cth103 | Status | new => resolved |
2012-04-11 10:08 | cth103 | Resolution | open => fixed |
2012-04-11 10:08 | cth103 | Assigned To | => cth103 |
2012-05-23 15:08 | cth103 | Target Version | 3.0 beta4 => 3.0 |
2020-04-19 20:16 | system | Note Added: 0023025 | |
2020-04-19 20:16 | system | Status | resolved => closed |